-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New community layout for Savage65 #24690
Open
ChrisGVE
wants to merge
15
commits into
qmk:master
Choose a base branch
from
ChrisGVE:savage65
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+129
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the release 1 of this keyboard.
Removing the uppercase R1 folder
- Added the layout LAYOUT_65_ansi_blocker_tsangan_split_bs to the community layouts.
Is there anything else I should do to have this request reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is the addition of a new tsangan/split-bs layout to keyboard.json.
Description
Currently, the keyboard ANSI layouts offer either a tsangan version (7u spacebar) or a standard version (6.25u spacebar) with a split backspace; there is no tansgan with a split spacebar. This pull request adds the missing combination.
The change is included in the
keyboard.json
file, which has been checked withqmk format-json -i
to apply the project standards to the file format.Types of Changes
Issues Fixed or Closed by This PR
Checklist