Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New community layout for Savage65 #24690

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

ChrisGVE
Copy link
Contributor

@ChrisGVE ChrisGVE commented Dec 8, 2024

The change is the addition of a new tsangan/split-bs layout to keyboard.json.

Description

Currently, the keyboard ANSI layouts offer either a tsangan version (7u spacebar) or a standard version (6.25u spacebar) with a split backspace; there is no tansgan with a split spacebar. This pull request adds the missing combination.

The change is included in the keyboard.json file, which has been checked with qmk format-json -i to apply the project standards to the file format.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ChrisGVE
Copy link
Contributor Author

Is there anything else I should do to have this request reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant