Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude external userspace from lint checking #24680

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 6, 2024

Description

Updated qmk lint default behaviour of checking "default-ish" keymaps to ignore userspace.

There are a few things to consider,

  • someone might want to actually lint userspace keymaps?
    • not a ton of value right now, but with the recent keymap.json changes will become more important
    • can still do qmk lint -kb whatever -km my_important_keymap
  • -km all behaviour?
    • currently still checks userspace
    • would prefer not to have to add an additional --userspace/--no-userspace arg

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants