Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add System76 Launch 3 #24673

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

boehs
Copy link

@boehs boehs commented Dec 4, 2024

Description

Upstreams https://github.com/system76/qmk_firmware

Note: Errors shown while building:

⚠ system76/launch_3: Build marker "keyboard.json" not found.
☒ system76/launch_3: LAYOUT: Layout macro should not be defined within ".h" files.
gmake: Warning: File 'keyboards/system76/launch_3/halconf.h' has modification time 5572 s in the future

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added invalid pr_checklist_pending Needs changes as per the PR checklist labels Dec 4, 2024
@drashna
Copy link
Member

drashna commented Dec 4, 2024

At the very least, qmk migrate will help start the process of getting this up to snuff. But most of the config in rules.mk, and a lot of the config in config.h can and should be migrated to keyboard.json (and info.json renamed to keyboard.json). Also, the 2 additional keymaps should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid keyboard keymap pr_checklist_pending Needs changes as per the PR checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants