-
-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition to the Apple Globe key code to QMK #24661
base: develop
Are you sure you want to change the base?
Conversation
for the release 1 of this keyboard.
Removing the uppercase R1 folder
This commit is based on lordpixel23 commit [d390fff](lordpixel23@d39033f)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave the rest of the review for the team -- they know more about the status of this stuff than what I do.
Co-authored-by: Ryan <[email protected]>
SHARE_EP_ENABLE was incorrectly set with GLOBE_KEY_ENABLE, what was needed is to set the KEYBOARD_SHARED_EP instead. This corrects it.
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Ryan <[email protected]>
Please undo the last merge commit. |
Now everything else is gone... |
Ok we should be back on track, sorry about the mishap. |
Is there anything truly still open or can this land? |
Nothing on my end |
I can't speak for others, but I was waiting on @fauxpark, as he has more experience with the USB endpoint stuff, and the apple FN/globe key stuff. However, develop isn't merged until end of feb |
To be completely honest, I'm still hesitant to hit approve on this myself simply due to the fact the only known way to make this key fully functional is to spoof the VID/PID. My initial goal way back when was to figure out how the Fn key worked as it pertained to the F-keys, and as I learned more about that it became clear that their behaviour changes based on the particular Apple keyboard model. So it seems to me that the Globe key in this current implementation will never really be able to do everything it can on a real device - by design. By all means, if people are happy with this in its current state, go ahead. It's already got two green ticks. Great work and not your fault @ChrisGVE, but to me personally, it doesn't quite close the case, which is a shame. |
I use it every day as it is because it is already useful. It is frustrating it cannot be 100% but if we find a way to do that it can always be in some future PR. |
Can we clearly document the full list of shortcomings before merge, then? A single footnote is a bit hard to link to when it the next person who comes along complains that it doesn’t work as per their Apple-branded device. |
This is really a shame because I am using this key on all my boards, and I have a few see my userspace repo without any problem. I don't have to change VIP/PID to make it work, whether I tap the key to obtain the emoji picker dialog or when I use it in combination with other keys (either as a single key or when using a hold-esc key + other key on HHKB). I think I gave a list of cases where it does not work earlier in this PR, and the documentation could be changed to make it more obvious, but I still stand by its usefulness. (My only challenge will be to port it back to the Keychron board Q60 Max, which is based on an earlier version of QMK...) |
The change brings the Apple Globe Key as
KC_GLOBE
to QMK.Description
The change is based mainly on @lordpixel23 QMK patch and is being discussed in depth in QMK Apple Fn Key created by @fauxpark.
Importantly, this change does not rely on VID/PID to be set on specific values.
In addition to the patch mentioned above, it introduces a new compilation flag,
GLOBE_KEY_ENABLE
such that:(a) the required
KEYBOARD_SHARE_EP
is enabled when the Globe keycode is used(b) keyboards or user layouts can make use of this definition for further customizations
The QMK documentation has been amended accordingly.
Certain key combinations are not yet working, though; in particular, 🌐︎+arrow or 🌐︎+FN do not work.
Thanks go to the input of many contributors, as this topic has been long discussed: @fauxpark, @HVR88, @drashna, and @lordpixel23.
Types of Changes
Issues Fixed or Closed by This PR
Checklist