Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD NCR80 ALPS SKFL/FR #24625

Merged
merged 9 commits into from
Dec 3, 2024
Merged

ADD NCR80 ALPS SKFL/FR #24625

merged 9 commits into from
Dec 3, 2024

Conversation

MaiTheSan
Copy link
Contributor

@MaiTheSan MaiTheSan commented Nov 20, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/salane/ncr80alpsskfl/keyboard.json Outdated Show resolved Hide resolved
keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team December 2, 2024 04:04
@waffle87 waffle87 merged commit 191172a into qmk:master Dec 3, 2024
3 checks passed
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 5, 2024
* ADD NCR80 ALPS SKFL/FR

* fix

* Update config.h

* Update config.h

* Update keyboards/salane/ncr80alpsskfl/keyboard.json

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/readme.md

Co-authored-by: jack <[email protected]>

---------

Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: jack <[email protected]>
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
* ADD NCR80 ALPS SKFL/FR

* fix

* Update config.h

* Update config.h

* Update keyboards/salane/ncr80alpsskfl/keyboard.json

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/readme.md

Co-authored-by: jack <[email protected]>

---------

Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: jack <[email protected]>
eliseomartelli pushed a commit to eliseomartelli/qmk_firmware that referenced this pull request Dec 9, 2024
* ADD NCR80 ALPS SKFL/FR

* fix

* Update config.h

* Update config.h

* Update keyboards/salane/ncr80alpsskfl/keyboard.json

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/readme.md

Co-authored-by: jack <[email protected]>

---------

Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: jack <[email protected]>
waffle87 added a commit to waffle87/qmk_firmware that referenced this pull request Dec 10, 2024
* ADD NCR80 ALPS SKFL/FR

* fix

* Update config.h

* Update config.h

* Update keyboards/salane/ncr80alpsskfl/keyboard.json

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/readme.md

Co-authored-by: jack <[email protected]>

---------

Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: jack <[email protected]>
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
* ADD NCR80 ALPS SKFL/FR

* fix

* Update config.h

* Update config.h

* Update keyboards/salane/ncr80alpsskfl/keyboard.json

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keymaps/default/keymap.c

Co-authored-by: Duncan Sutherland <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/salane/ncr80alpsskfl/readme.md

Co-authored-by: jack <[email protected]>

---------

Co-authored-by: Duncan Sutherland <[email protected]>
Co-authored-by: jack <[email protected]>
@fauxpark
Copy link
Member

@MaiTheSan This board is missing some layouts. Please fix this.

⚠ salane/ncr80alpsskfl: "LAYOUT_all" should be "LAYOUT" unless additional layouts are provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants