Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add keyboard suika27melo #24616

Merged
merged 6 commits into from
Dec 2, 2024
Merged

add keyboard suika27melo #24616

merged 6 commits into from
Dec 2, 2024

Conversation

suikagiken
Copy link
Contributor

@suikagiken suikagiken commented Nov 19, 2024 •
edited
Loading

Description

Add keyboard suikagiken/suika27melo.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 reviewed Nov 19, 2024
View reviewed changes
keyboards/suikagiken/suika27melo/keyboard.json Outdated Show resolved Hide resolved
keyboards/suikagiken/suika27melo/keyboard.json Outdated Show resolved Hide resolved
keyboards/suikagiken/suika27melo/readme.md Outdated Show resolved Hide resolved
keyboards/suikagiken/suika27melo/readme.md Outdated Show resolved Hide resolved
keyboards/suikagiken/suika27melo/readme.md Outdated Show resolved Hide resolved
suikagiken
suikagiken commented Nov 19, 2024
View reviewed changes
Copy link
Contributor Author

@suikagiken suikagiken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waffle87 Thank you for your suggestion.
I have made the corrections.

@suikagiken suikagiken marked this pull request as ready for review November 19, 2024 08:39
@waffle87 waffle87 merged commit cd286e4 into qmk:master Dec 2, 2024
3 checks passed
@suikagiken suikagiken mentioned this pull request Dec 4, 2024
Merged
4 tasks
fauxpark
fauxpark reviewed Dec 5, 2024
View reviewed changes
keyboards/suikagiken/suika27melo/keymaps/default/keymap.json
@@ -0,0 +1,12 @@
{
"author": "@suikagiken",
"keyboard": "suikagiken/suika85ergo",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is wrong; the board does not compile properly in the Configurator. Please fix this.

keyboards/suikagiken/suika27melo/keymaps/midi/keymap.json
@@ -0,0 +1,12 @@
{
"author": "@suikagiken",
"keyboard": "suikagiken/suika85ergo",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

@suikagiken
Copy link
Contributor Author

@fauxpark Thank you for the advice. I have issued a PR for the corrections here.
#24677

ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 5, 2024
@suikagiken @waffle87 @ilham-agustiawan
[Keyboard] Add suika27melo (qmk#24616)
03d74a8 
* add keyboard suika27melo

* Update keyboards/suikagiken/suika27melo/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/readme.md

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/readme.md

Co-authored-by: jack <[email protected]>

* change to imgur link

---------

Co-authored-by: jack <[email protected]>
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@suikagiken @waffle87 @DmNosachev
[Keyboard] Add suika27melo (qmk#24616)
310f308 
* add keyboard suika27melo

* Update keyboards/suikagiken/suika27melo/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/readme.md

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/readme.md

Co-authored-by: jack <[email protected]>

* change to imgur link

---------

Co-authored-by: jack <[email protected]>
@suikagiken suikagiken mentioned this pull request Dec 7, 2024
Merged
9 tasks
eliseomartelli pushed a commit to eliseomartelli/qmk_firmware that referenced this pull request Dec 9, 2024
@suikagiken @waffle87 @eliseomartelli
[Keyboard] Add suika27melo (qmk#24616)
d3d07ba 
* add keyboard suika27melo

* Update keyboards/suikagiken/suika27melo/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/readme.md

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/readme.md

Co-authored-by: jack <[email protected]>

* change to imgur link

---------

Co-authored-by: jack <[email protected]>
waffle87 added a commit to waffle87/qmk_firmware that referenced this pull request Dec 10, 2024
@suikagiken @waffle87
[Keyboard] Add suika27melo (qmk#24616)
fa93237 
* add keyboard suika27melo

* Update keyboards/suikagiken/suika27melo/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/readme.md

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/readme.md

Co-authored-by: jack <[email protected]>

* change to imgur link

---------

Co-authored-by: jack <[email protected]>
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@suikagiken @waffle87 @SyrupSplashin
[Keyboard] Add suika27melo (qmk#24616)
66b3d7a 
* add keyboard suika27melo

* Update keyboards/suikagiken/suika27melo/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/keyboard.json

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/readme.md

Co-authored-by: jack <[email protected]>

* Update keyboards/suikagiken/suika27melo/readme.md

Co-authored-by: jack <[email protected]>

* change to imgur link

---------

Co-authored-by: jack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suikagiken @drashna @fauxpark @waffle87