Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Add Binepad BNK8 keyboard #24598

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

vinorodrigues
Copy link
Contributor

Description

Add Binepad BNK8 keyboard - a 3x3 macropad with rotary encoder.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

(n/a)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/binepad/bnk8/keyboard.json Outdated Show resolved Hide resolved
@waffle87 waffle87 requested a review from a team November 15, 2024 03:16
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RGB_ -> RM_ keycodes after this round of breaking changes.

keyboards/binepad/bnk8/keymaps/default/keymap.json Outdated Show resolved Hide resolved
keyboards/binepad/bnk8/keymaps/default/keymap.json Outdated Show resolved Hide resolved
@waffle87 waffle87 merged commit 3c324cb into qmk:master Dec 4, 2024
3 checks passed
pull bot pushed a commit to kruton/qmk_firmware that referenced this pull request Dec 4, 2024
* Add Binepad BNK8 keyboard

* Moved keymap.c to keymap.json

* Fix product page URL

* RGB_ -> RM_ keycodes after this round of breaking changes

Co-authored-by: Ryan <[email protected]>

---------

Co-authored-by: Ryan <[email protected]>
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 5, 2024
* Add Binepad BNK8 keyboard

* Moved keymap.c to keymap.json

* Fix product page URL

* RGB_ -> RM_ keycodes after this round of breaking changes

Co-authored-by: Ryan <[email protected]>

---------

Co-authored-by: Ryan <[email protected]>
@vinorodrigues vinorodrigues deleted the vr-binepad-bnk8 branch December 5, 2024 15:26
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
* Add Binepad BNK8 keyboard

* Moved keymap.c to keymap.json

* Fix product page URL

* RGB_ -> RM_ keycodes after this round of breaking changes

Co-authored-by: Ryan <[email protected]>

---------

Co-authored-by: Ryan <[email protected]>
eliseomartelli pushed a commit to eliseomartelli/qmk_firmware that referenced this pull request Dec 9, 2024
* Add Binepad BNK8 keyboard

* Moved keymap.c to keymap.json

* Fix product page URL

* RGB_ -> RM_ keycodes after this round of breaking changes

Co-authored-by: Ryan <[email protected]>

---------

Co-authored-by: Ryan <[email protected]>
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Dec 10, 2024
* Add Binepad BNK8 keyboard

* Moved keymap.c to keymap.json

* Fix product page URL

* RGB_ -> RM_ keycodes after this round of breaking changes

Co-authored-by: Ryan <[email protected]>

---------

Co-authored-by: Ryan <[email protected]>
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
* Add Binepad BNK8 keyboard

* Moved keymap.c to keymap.json

* Fix product page URL

* RGB_ -> RM_ keycodes after this round of breaking changes

Co-authored-by: Ryan <[email protected]>

---------

Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants