Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pixel Rain to respect LED range limits #24532

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Update Pixel Rain to respect LED range limits #24532

merged 1 commit into from
Oct 28, 2024

Conversation

filterpaper
Copy link
Contributor

Description

Improved effect with update to LED index within led_min and led_max limits

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Oct 27, 2024
@filterpaper filterpaper force-pushed the pixelrain-ledlimits branch 3 times, most recently from 4dbeec4 to 57cbb02 Compare October 27, 2024 11:42
@filterpaper
Update Pixel Rain to respect LED range limits
132b01a 
Improved effect with update to LED index within `led_min` and `led_max` limits
@drashna drashna requested a review from a team October 28, 2024 00:33
@drashna drashna merged commit d9fedce into qmk:develop Oct 28, 2024
4 checks passed
@filterpaper filterpaper deleted the pixelrain-ledlimits branch October 28, 2024 06:24
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@filterpaper @ilham-agustiawan
Update Pixel Rain to respect LED range limits (qmk#24532)
ef0b984
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@filterpaper @smallketchup82
Update Pixel Rain to respect LED range limits (qmk#24532)
054995d
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@filterpaper @jlaptavi
Update Pixel Rain to respect LED range limits (qmk#24532)
adff304
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@filterpaper @DmNosachev
Update Pixel Rain to respect LED range limits (qmk#24532)
bad443b
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@filterpaper @SyrupSplashin
Update Pixel Rain to respect LED range limits (qmk#24532)
bf0d47f
LeonMusCoden pushed a commit to LeonMusCoden/qmk_firmware that referenced this pull request Jan 5, 2025
@filterpaper @LeonMusCoden
Update Pixel Rain to respect LED range limits (qmk#24532)
c79dbab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @fauxpark