Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Starlight matrix effects #24521

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Update Starlight matrix effects #24521

merged 1 commit into from
Jan 2, 2025

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Oct 25, 2024 •
edited
Loading

Description

  • Improved effect to update LED index within led_min and led_max limits
  • Check for LED flags

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Oct 25, 2024
@filterpaper filterpaper force-pushed the starlight-refactor branch 2 times, most recently from 21477e3 to 29a929d Compare October 25, 2024 02:00
@filterpaper filterpaper changed the title Refactor Starlight matrix effect Refactor Starlight matrix effects Oct 25, 2024
@drashna drashna requested a review from a team October 25, 2024 02:50
@filterpaper filterpaper force-pushed the starlight-refactor branch 2 times, most recently from f6979b1 to 34ecdf7 Compare October 27, 2024 01:14
@filterpaper filterpaper changed the title Refactor Starlight matrix effects Update Starlight matrix effects Oct 27, 2024
@filterpaper filterpaper requested a review from drashna October 27, 2024 01:14
@filterpaper
Copy link
Contributor Author

@drashna There are significant changes since your last approval.

@filterpaper filterpaper force-pushed the starlight-refactor branch 4 times, most recently from cebf21e to 1d3fbd3 Compare October 27, 2024 23:48
drashna
drashna requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to make the animation run slower (effect wise, not scan rate wise).

quantum/rgb_matrix/animations/starlight_anim.h Outdated Show resolved Hide resolved
quantum/rgb_matrix/animations/starlight_dual_hue_anim.h Outdated Show resolved Hide resolved
@filterpaper
Copy link
Contributor Author

This appears to make the animation run slower (effect wise, not scan rate wise).

There were no changes to the interval time scaling though.

@drashna
Copy link
Member

drashna commented Oct 28, 2024

This appears to make the animation run slower (effect wise, not scan rate wise).

There were no changes to the interval time scaling though.

Odd. More so that I can't reproduce it. So it may have been a syncing related issue.

@filterpaper
Copy link
Contributor Author

filterpaper commented Oct 28, 2024 •
edited
Loading

This appears to make the animation run slower (effect wise, not scan rate wise).

There were no changes to the interval time scaling though.

Odd. More so that I can't reproduce it. So it may have been a syncing related issue.

These effects are a bit "jittery" because of the step intervals. The revision in #24137 is a lot better and could be incorporated into the "hue" and "sat" version in another revision.

@drashna drashna requested a review from a team October 28, 2024 01:44
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 12, 2024
@filterpaper
Update Starlight matrix effects
b886e36 
* Improved effect to update LED index within led_min and led_max limits
* Check for LED flags
@filterpaper
Copy link
Contributor Author

Pull request is still awaiting review.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Dec 13, 2024
@drashna drashna added awaiting review breaking_change_2025q1 Targeting breaking changes Q1 2025 labels Dec 22, 2024
@drashna drashna merged commit cf975e2 into qmk:develop Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
awaiting review breaking_change_2025q1 Targeting breaking changes Q1 2025 core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @tzarc