Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pointing tests #24513

Merged
merged 9 commits into from
Nov 23, 2024
Merged

Add pointing tests #24513

merged 9 commits into from
Nov 23, 2024

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented Oct 22, 2024 •
edited
Loading

Description

Opened for eyeballs, first time implementing tests and haven't fully decided on what should be tested.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Oct 22, 2024
@daskygit daskygit added the no-ci Signals to the CI runners not to build. label Oct 22, 2024
@drashna
Copy link
Member

drashna commented Oct 22, 2024

haven't fully decided on what should be tested.

What you have seems like a lot of good tests, already. Having the tests is great and can be built out over time.

That said, tests for the mousekey behavior would be fantastic, long term.

@drashna drashna requested a review from a team October 22, 2024 16:37
@daskygit daskygit marked this pull request as ready for review October 23, 2024 23:44
@daskygit
Copy link
Member Author

Did a little reworking/renaming should be ready for review.

@drashna drashna requested a review from a team October 28, 2024 06:30
@zvecr zvecr merged commit 1f7d109 into qmk:develop Nov 23, 2024
4 checks passed
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@daskygit @ilham-agustiawan
Add pointing tests (qmk#24513)
124bfd2
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@daskygit @smallketchup82
Add pointing tests (qmk#24513)
66e92e2
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@daskygit @jlaptavi
Add pointing tests (qmk#24513)
6e4b454
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@daskygit @DmNosachev
Add pointing tests (qmk#24513)
0cb69bb
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@daskygit @SyrupSplashin
Add pointing tests (qmk#24513)
233b18c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core no-ci Signals to the CI runners not to build.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daskygit @drashna @zvecr