-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change From info.json to keyboard.json #24498
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is, info.json
is still very much so valid and the same content can live in both info.json
and keyboard.json
. keyboard.json
is just a build marker for a valid keyboard to compile. For example:
sample_keyboard
├── info.json
├── keymaps
│ └── default
├── rev1
│ └── keyboard.json
└── rev2
└── keyboard.json
Here, building sample_keyboard
(qmk compile -kb sample_keyboard -km default
) is not valid, and requires the user to specify a version to use, that's why there is no keyboard.json
at the top level keyboard directory.
What would be preferable is adding notes explaining what keyboard.json
's purpose is and how it's different from info.json
.
Okay, I see what you did there. Are there any real examples of this in the codebase? I generally cannot get my code to compile without renaming all of my instances of info.json (can definitely be a skill issue). |
An example would be boardsource/microdox. Where If you're having trouble compiling firmware, I would suggest you join the QMK Discord and we are happy to help you there. But in general, you need a valid build marker in your keyboard directory (ie. a |
No, this is perfect! Thank you! |
added context based on changelog 20240526.
The latest commit contains the proper changes to fully replace most instances of |
I just forgot to save the document...
Thank you for your contribution! |
Changed as many instances of "info.json" references in the documentation as I could find.
Description
Since the change from info.json to keyboard.json I have been regularly confused because I am an ADHD nerd. I figured some updates here would help newcomers as well.
Types of Changes
Issues Fixed or Closed by This PR
Checklist