Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename RGB and HSV structs #24471

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Rename RGB and HSV structs #24471

merged 3 commits into from
Oct 11, 2024

Conversation

fauxpark
Copy link
Member

Description

Now that the WS2812-ness of the RGB struct has been removed, the name rgb_led_t should go too.

These structs are now called rgb_t and hsv_t for consistency. The old names RGB, rgb_led_t, and HSV remain as typedefs for backward compatibility for now.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 11, 2024 07:41
@drashna drashna requested a review from a team October 11, 2024 18:51
@zvecr zvecr merged commit 6129af9 into qmk:develop Oct 11, 2024
4 checks passed
@fauxpark fauxpark deleted the rgb-hsv-structs-rename branch October 12, 2024 03:12
@fauxpark fauxpark mentioned this pull request Oct 12, 2024
Merged
14 tasks
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@fauxpark @ilham-agustiawan
Rename RGB and HSV structs (qmk#24471)
b00b33c
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@fauxpark @smallketchup82
Rename RGB and HSV structs (qmk#24471)
51e481f
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@fauxpark @jlaptavi
Rename RGB and HSV structs (qmk#24471)
d68f50c
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@fauxpark @DmNosachev
Rename RGB and HSV structs (qmk#24471)
50bba87
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@fauxpark @SyrupSplashin
Rename RGB and HSV structs (qmk#24471)
f5ec685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @zvecr