Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmk find: expand operator support #24468

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 9, 2024

Description

Replacing the singular key = value expression with support for the following operators:

  • key == value: Match targets where key is equal to value. May include wildcards such as * and ?.
  • key != value: Match targets where key is not value. May include wildcards such as * and ?.
  • key < value: Match targets where key is a number less than value.
  • key > value: Match targets where key is a number greater than value.
  • key <= value: Match targets where key is a number less than or equal to value.
  • key >= value: Match targets where key is a number greater than or equal to value.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark marked this pull request as ready for review November 21, 2024 09:01
@tzarc tzarc merged commit 65a8a5f into qmk:develop Nov 21, 2024
6 checks passed
@fauxpark fauxpark deleted the qmk-find-operators branch November 21, 2024 13:45
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants