Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add h88 gen2 #24454

Merged
merged 10 commits into from
Dec 2, 2024
Merged

Add h88 gen2 #24454

merged 10 commits into from
Dec 2, 2024

Conversation

hineybush
Copy link
Contributor

Description

Add h88 gen 2 PCB.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87 waffle87 requested a review from a team September 30, 2024 21:40
dunk2k
dunk2k suggested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Add compatible Community Layout support
  2. Correct ISO Enter key's sequence position to match respective Community Layout

keyboards/hineybush/h88_g2/keyboard.json Show resolved Hide resolved
keyboards/hineybush/h88_g2/keyboard.json Show resolved Hide resolved
keyboards/hineybush/h88_g2/keyboard.json Show resolved Hide resolved
keyboards/hineybush/h88_g2/keyboard.json Show resolved Hide resolved
keyboards/hineybush/h88_g2/keyboard.json Show resolved Hide resolved
keyboards/hineybush/h88_g2/keyboard.json Show resolved Hide resolved
keyboards/hineybush/h88_g2/keyboard.json Show resolved Hide resolved
keyboards/hineybush/h88_g2/keyboard.json Show resolved Hide resolved
@hineybush hineybush requested a review from fauxpark October 6, 2024 16:16
@hineybush
Copy link
Contributor Author

@fauxpark hi :)

drashna
drashna reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick:

keyboards/hineybush/h88_g2/config.h Outdated Show resolved Hide resolved
@waffle87 waffle87 merged commit 09dfbf8 into qmk:master Dec 2, 2024
2 of 3 checks passed
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 5, 2024
@hineybush @waffle87
@drashna @ilham-agustiawan
[Keyboard] Add h88 gen2 (qmk#24454)
26bd076 
* initial commit

* small updates

* matrix fix

* fix rgb lighting

* updates

* fix rgb pin

* pin fixes

* readme update

* json formatting

* Update keyboards/hineybush/h88_g2/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

---------

Co-authored-by: jack <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@hineybush @waffle87
@drashna @DmNosachev
[Keyboard] Add h88 gen2 (qmk#24454)
ca3ac61 
* initial commit

* small updates

* matrix fix

* fix rgb lighting

* updates

* fix rgb pin

* pin fixes

* readme update

* json formatting

* Update keyboards/hineybush/h88_g2/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

---------

Co-authored-by: jack <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
eliseomartelli pushed a commit to eliseomartelli/qmk_firmware that referenced this pull request Dec 9, 2024
@hineybush @waffle87
@drashna @eliseomartelli
[Keyboard] Add h88 gen2 (qmk#24454)
d3a39cd 
* initial commit

* small updates

* matrix fix

* fix rgb lighting

* updates

* fix rgb pin

* pin fixes

* readme update

* json formatting

* Update keyboards/hineybush/h88_g2/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

---------

Co-authored-by: jack <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
waffle87 added a commit to waffle87/qmk_firmware that referenced this pull request Dec 10, 2024
@hineybush @waffle87 @drashna
[Keyboard] Add h88 gen2 (qmk#24454)
10a92a7 
* initial commit

* small updates

* matrix fix

* fix rgb lighting

* updates

* fix rgb pin

* pin fixes

* readme update

* json formatting

* Update keyboards/hineybush/h88_g2/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

---------

Co-authored-by: jack <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@hineybush @waffle87
@drashna @SyrupSplashin
[Keyboard] Add h88 gen2 (qmk#24454)
cab9e80 
* initial commit

* small updates

* matrix fix

* fix rgb lighting

* updates

* fix rgb pin

* pin fixes

* readme update

* json formatting

* Update keyboards/hineybush/h88_g2/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

---------

Co-authored-by: jack <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hineybush @drashna @fauxpark @waffle87 @dunk2k