Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Somei70 addition #24444

Merged
merged 15 commits into from
Dec 24, 2024
Merged

Somei70 addition #24444

merged 15 commits into from
Dec 24, 2024

Conversation

gzowski
Copy link
Contributor

@gzowski gzowski commented Sep 27, 2024

Somei70 - 70 key keyboard with OLED and RGB LED's

Description

New keyboard to add to QMK. formatted json, kept everything in keyboard.json where possible. Only one layout being default but with VIA_ENABLE set.
Not sure if this needed to be in it's own VIA keymap or whether default was fine.
Link to projects github currently private while build guide is being written up.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/somei70/keyboard.json Show resolved Hide resolved
keyboards/somei70/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/somei70/rules.mk Outdated Show resolved Hide resolved
keyboards/somei70/keymaps/default/keymap.c Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team September 27, 2024 12:29
@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Sep 27, 2024
@gzowski gzowski requested a review from fauxpark October 7, 2024 08:11
@gzowski
Copy link
Contributor Author

gzowski commented Oct 31, 2024

Do I need to make any further changes?

keyboards/somei70/keyboard.json Show resolved Hide resolved
keyboards/somei70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/somei70/keymaps/default/keymap.c Show resolved Hide resolved
keyboards/somei70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/somei70/somei70.c Outdated Show resolved Hide resolved
keyboards/somei70/somei70.c Outdated Show resolved Hide resolved
keyboards/somei70/somei70.c Outdated Show resolved Hide resolved
keyboards/somei70/somei70.c Outdated Show resolved Hide resolved
@gzowski
Copy link
Contributor Author

gzowski commented Nov 26, 2024

Forgot I still had this open, Is there anything I'm missing out at this point to be added/modified?

keyboards/somei70/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/somei70/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/somei70/somei70.c Outdated Show resolved Hide resolved
keyboards/somei70/somei70.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team December 24, 2024 06:30
@waffle87 waffle87 merged commit 40c93bc into qmk:master Dec 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants