Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cornia keyboard #24442

Merged
merged 15 commits into from
Dec 3, 2024
Merged

Add cornia keyboard #24442

merged 15 commits into from
Dec 3, 2024

Conversation

Vaarai
Copy link
Contributor

@Vaarai Vaarai commented Sep 26, 2024 •
edited
Loading

Description

Addition of Cornia keyboard that's featuring :

  • 3x6 column strongly staggered keys and 3 thumb keys
  • Hotswap sockets (Compatible with Kailh and Gateron)
  • All 1u keys
  • Same PCB for both hands (revesible)
  • No diode to solder (No switch matrix)
  • Per key adressable RGB leds (SK6812MINI-E)
  • QMK Handedness pin (see QMK documentation)
  • I2C OLED Display
  • I2C Cirque Trackpad

PR include:

  • Cornia v1 keyboard
  • Cornia v0.6 keyboard
  • Cornia default (QWERTY) keymap
  • Cornia Fire (Oxey) keymap (Enabling all available Cornia features)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also strongly advise that keyboards/cornia/v1_no_led/ is removed as it doesnt really add much value. There isnt much side effects to running with a disconnected ws2812 chain, or you could just directly disable the RGB Matrix feature. For example

make cornia:default RGB_MATRIX_ENABLE=no

Which gives us one less rather pointless build target to run in our CI builds.

keyboards/cornia/rules.mk Outdated Show resolved Hide resolved
keyboards/cornia/v1_no_led/rules.mk Outdated Show resolved Hide resolved
keyboards/cornia/v1/rules.mk Outdated Show resolved Hide resolved
keyboards/cornia/v0_6/rules.mk Outdated Show resolved Hide resolved
keyboards/cornia/v0_6/keyboard.json Outdated Show resolved Hide resolved
keyboards/cornia/v1/keyboard.json Outdated Show resolved Hide resolved
keyboards/cornia/v1_no_led/keyboard.json Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/tap_dances.c Show resolved Hide resolved
keyboards/cornia/v1/keyboard.json Outdated Show resolved Hide resolved
keyboards/cornia/v1/keyboard.json Outdated Show resolved Hide resolved
@Vaarai Vaarai requested a review from zvecr September 26, 2024 22:04
@Vaarai
Copy link
Contributor Author

Vaarai commented Sep 26, 2024

Thanks @zvecr for these suggestions.

There's just one question left on the tap_dance_actions array outside keymap.c.

PR updated, I'll let you review it.

drashna
drashna requested changes Oct 2, 2024
View reviewed changes
keyboards/cornia/keymaps/fire/callback_oled.c Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/config.h Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/config.h Show resolved Hide resolved
keyboards/cornia/keymaps/fire/config.h Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/oled_routines.c Outdated Show resolved Hide resolved
keyboards/cornia/readme.md Outdated Show resolved Hide resolved
@Vaarai Vaarai requested a review from drashna October 2, 2024 19:19
drashna
drashna requested changes Oct 3, 2024
View reviewed changes
keyboards/cornia/cornia.c Outdated Show resolved Hide resolved
keyboards/cornia/cornia.h Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/callback_oled.c Outdated Show resolved Hide resolved
keyboards/cornia/cornia.c Show resolved Hide resolved
keyboards/cornia/v1/rules.mk Outdated Show resolved Hide resolved
@Vaarai Vaarai requested a review from drashna October 3, 2024 11:49
@Vaarai
Copy link
Contributor Author

Vaarai commented Oct 15, 2024

Thanks @zvecr, @drashna for these suggestions.

PR updated, I let you review it.

drashna
drashna requested changes Oct 15, 2024
View reviewed changes
keyboards/cornia/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/callback_system.c Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/callback_oled.c Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/callback_pointing_device.c Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/rules.mk Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/config.h Show resolved Hide resolved
@Vaarai Vaarai force-pushed the cornia branch 3 times, most recently from 1e19be8 to 4c29620 Compare October 15, 2024 23:35
@Vaarai
Copy link
Contributor Author

Vaarai commented Oct 15, 2024

Thanks again @zvecr, @drashna for these suggestions.

PR updated and tested on target hardware, I let you review it.

@Vaarai Vaarai requested a review from drashna October 15, 2024 23:37
@Vaarai
Copy link
Contributor Author

Vaarai commented Oct 16, 2024

I spotted a regression in cornia.c/.h, it's now fixed (and tested on my side), I let you review it.

@Vaarai
Copy link
Contributor Author

Vaarai commented Oct 25, 2024

Thanks @zvecr, @drashna for your reviews, PR ready to be reviewed.

drashna
drashna approved these changes Oct 25, 2024
View reviewed changes
keyboards/cornia/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/cornia/rules.mk Outdated Show resolved Hide resolved
@Vaarai
Copy link
Contributor Author

Vaarai commented Oct 30, 2024

Hello @zvecr, @drashna, could I do additional things to move forward ?

waffle87
waffle87 requested changes Nov 11, 2024
View reviewed changes
keyboards/cornia/cornia.c Outdated Show resolved Hide resolved
keyboards/cornia/v0_6/config.h Outdated Show resolved Hide resolved
keyboards/cornia/v1/config.h Outdated Show resolved Hide resolved
keyboards/cornia/v0_6/mcuconf.h Outdated Show resolved Hide resolved
keyboards/cornia/v1/mcuconf.h Outdated Show resolved Hide resolved
keyboards/cornia/v0_6/keyboard.json Outdated Show resolved Hide resolved
keyboards/cornia/info.json Outdated Show resolved Hide resolved
keyboards/cornia/v1/keyboard.json Outdated Show resolved Hide resolved
keyboards/cornia/v0_6/keyboard.json Outdated Show resolved Hide resolved
keyboards/cornia/v1/keyboard.json Outdated Show resolved Hide resolved
lesshonor
lesshonor suggested changes Nov 11, 2024
View reviewed changes
keyboards/cornia/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/keymap.h Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/keymap.c Outdated Show resolved Hide resolved
keyboards/cornia/readme.md Outdated Show resolved Hide resolved
@Vaarai
Copy link
Contributor Author

Vaarai commented Nov 11, 2024

Thank you very much @waffle87 and @lesshonor, I let you review the updated PR.

@Vaarai Vaarai requested review from waffle87 and lesshonor November 11, 2024 19:43
waffle87
waffle87 requested changes Dec 2, 2024
View reviewed changes
keyboards/cornia/config.h Outdated Show resolved Hide resolved
keyboards/cornia/info.json Show resolved Hide resolved
keyboards/cornia/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/keymap.c Outdated Show resolved Hide resolved
keyboards/cornia/keymaps/fire/rules.mk Outdated Show resolved Hide resolved
keyboards/cornia/readme.md Outdated Show resolved Hide resolved
keyboards/cornia/readme.md Outdated Show resolved Hide resolved
keyboards/cornia/readme.md Outdated Show resolved Hide resolved
@Vaarai Vaarai requested a review from waffle87 December 2, 2024 21:33
waffle87
waffle87 reviewed Dec 3, 2024
View reviewed changes
keyboards/cornia/mcuconf.h Show resolved Hide resolved
keyboards/cornia/mcuconf.h Outdated Show resolved Hide resolved
@Vaarai Vaarai requested a review from waffle87 December 3, 2024 07:49
@waffle87 waffle87 merged commit e7f1388 into qmk:master Dec 3, 2024
3 checks passed
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 5, 2024
@Vaarai @ilham-agustiawan
Add cornia keyboard (qmk#24442)
a3bd94a 
* Add cornia keyboard

* Update Fire keymap

* [Cornia/Doc] Host image on imgur

* [Cornia/config] Remove unnecessary defines

* [Cornia] Move I2C stuff to keyboard level

* [Cornia/config] Remove unnecessary defines & move all callbacks to keymap.c

* [Cornia] Use tri-layer in default keymap

* [Cornia/makefiles] remove license headers & root makefile

* [Cornia] Put common configuration to top keyboard level

* [Cornia] Remove unecessary custom keycodes

* [Cornia] Fix readme

* [Cornia] Fix RGB keycodes

* [Cornia] Fix config files

* [Cornia] Fix readme

* [Cornia] Fix mcuconf.h license
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@Vaarai @DmNosachev
Add cornia keyboard (qmk#24442)
b046fd6 
* Add cornia keyboard

* Update Fire keymap

* [Cornia/Doc] Host image on imgur

* [Cornia/config] Remove unnecessary defines

* [Cornia] Move I2C stuff to keyboard level

* [Cornia/config] Remove unnecessary defines & move all callbacks to keymap.c

* [Cornia] Use tri-layer in default keymap

* [Cornia/makefiles] remove license headers & root makefile

* [Cornia] Put common configuration to top keyboard level

* [Cornia] Remove unecessary custom keycodes

* [Cornia] Fix readme

* [Cornia] Fix RGB keycodes

* [Cornia] Fix config files

* [Cornia] Fix readme

* [Cornia] Fix mcuconf.h license
eliseomartelli pushed a commit to eliseomartelli/qmk_firmware that referenced this pull request Dec 9, 2024
@Vaarai @eliseomartelli
Add cornia keyboard (qmk#24442)
8d36177 
* Add cornia keyboard

* Update Fire keymap

* [Cornia/Doc] Host image on imgur

* [Cornia/config] Remove unnecessary defines

* [Cornia] Move I2C stuff to keyboard level

* [Cornia/config] Remove unnecessary defines & move all callbacks to keymap.c

* [Cornia] Use tri-layer in default keymap

* [Cornia/makefiles] remove license headers & root makefile

* [Cornia] Put common configuration to top keyboard level

* [Cornia] Remove unecessary custom keycodes

* [Cornia] Fix readme

* [Cornia] Fix RGB keycodes

* [Cornia] Fix config files

* [Cornia] Fix readme

* [Cornia] Fix mcuconf.h license
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Dec 10, 2024
@Vaarai @waffle87
Add cornia keyboard (qmk#24442)
7674ea5 
* Add cornia keyboard

* Update Fire keymap

* [Cornia/Doc] Host image on imgur

* [Cornia/config] Remove unnecessary defines

* [Cornia] Move I2C stuff to keyboard level

* [Cornia/config] Remove unnecessary defines & move all callbacks to keymap.c

* [Cornia] Use tri-layer in default keymap

* [Cornia/makefiles] remove license headers & root makefile

* [Cornia] Put common configuration to top keyboard level

* [Cornia] Remove unecessary custom keycodes

* [Cornia] Fix readme

* [Cornia] Fix RGB keycodes

* [Cornia] Fix config files

* [Cornia] Fix readme

* [Cornia] Fix mcuconf.h license
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@Vaarai @SyrupSplashin
Add cornia keyboard (qmk#24442)
fb41782 
* Add cornia keyboard

* Update Fire keymap

* [Cornia/Doc] Host image on imgur

* [Cornia/config] Remove unnecessary defines

* [Cornia] Move I2C stuff to keyboard level

* [Cornia/config] Remove unnecessary defines & move all callbacks to keymap.c

* [Cornia] Use tri-layer in default keymap

* [Cornia/makefiles] remove license headers & root makefile

* [Cornia] Put common configuration to top keyboard level

* [Cornia] Remove unecessary custom keycodes

* [Cornia] Fix readme

* [Cornia] Fix RGB keycodes

* [Cornia] Fix config files

* [Cornia] Fix readme

* [Cornia] Fix mcuconf.h license
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

@lesshonor lesshonor Awaiting requested review from lesshonor

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vaarai @drashna @zvecr @waffle87 @lesshonor