Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new keyboard "Jourkey" #24409

Merged
merged 8 commits into from
Dec 2, 2024
Merged

Add new keyboard "Jourkey" #24409

merged 8 commits into from
Dec 2, 2024

Conversation

takashicompany
Copy link
Contributor

@takashicompany takashicompany commented Sep 18, 2024 •
edited
Loading

Description

I have created a new keyboard and would appreciate a review.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Sep 18, 2024
View reviewed changes
keyboards/takashicompany/jourkey/readme.md Outdated Show resolved Hide resolved
keyboards/takashicompany/jourkey/keyboard.json
"vid": "0x7463"
},
"layouts": {
"LAYOUT": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • LAYOUT macro is missing key widths so it displays correctly
  • Missing a layout macro that has an iso key

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zvecr
Added value for Width.
After team discussion, it was decided to drop support for ISO-Enter.

@takashicompany takashicompany requested a review from zvecr October 9, 2024 15:43
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 26, 2024
@waffle87 waffle87 merged commit 5096693 into qmk:master Dec 2, 2024
3 checks passed
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 5, 2024
@takashicompany @zvecr @ilham-agustiawan
Add new keyboard "Jourkey" (qmk#24409)
7211b94 
* jourkey

* rotary encoder

* fix keymap

* jourkey

* format json

* Update keyboards/takashicompany/jourkey/readme.md

Co-authored-by: Joel Challis <[email protected]>

* fix layout

* Update readme.md

---------

Co-authored-by: Joel Challis <[email protected]>
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@takashicompany @zvecr @DmNosachev
Add new keyboard "Jourkey" (qmk#24409)
0f75ee5 
* jourkey

* rotary encoder

* fix keymap

* jourkey

* format json

* Update keyboards/takashicompany/jourkey/readme.md

Co-authored-by: Joel Challis <[email protected]>

* fix layout

* Update readme.md

---------

Co-authored-by: Joel Challis <[email protected]>
eliseomartelli pushed a commit to eliseomartelli/qmk_firmware that referenced this pull request Dec 9, 2024
@takashicompany @zvecr @eliseomartelli
Add new keyboard "Jourkey" (qmk#24409)
c108c53 
* jourkey

* rotary encoder

* fix keymap

* jourkey

* format json

* Update keyboards/takashicompany/jourkey/readme.md

Co-authored-by: Joel Challis <[email protected]>

* fix layout

* Update readme.md

---------

Co-authored-by: Joel Challis <[email protected]>
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Dec 10, 2024
@takashicompany @zvecr @waffle87
Add new keyboard "Jourkey" (qmk#24409)
9d5d132 
* jourkey

* rotary encoder

* fix keymap

* jourkey

* format json

* Update keyboards/takashicompany/jourkey/readme.md

Co-authored-by: Joel Challis <[email protected]>

* fix layout

* Update readme.md

---------

Co-authored-by: Joel Challis <[email protected]>
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@takashicompany @zvecr @SyrupSplashin
Add new keyboard "Jourkey" (qmk#24409)
bcf17f6 
* jourkey

* rotary encoder

* fix keymap

* jourkey

* format json

* Update keyboards/takashicompany/jourkey/readme.md

Co-authored-by: Joel Challis <[email protected]>

* fix layout

* Update readme.md

---------

Co-authored-by: Joel Challis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@takashicompany @drashna @zvecr @waffle87