Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Leopold keyboards and add support for new FC980C controller #24378

Closed
wants to merge 10 commits into from
Closed

Refactor Leopold keyboards and add support for new FC980C controller #24378

wants to merge 10 commits into from

Conversation

wlhlm
Copy link
Contributor

@wlhlm wlhlm commented Sep 9, 2024 •
edited
Loading

This replaces #22260. I was unable to reopen that PR, apologies for making a new one.

This adds configs for a new FC980C replacement controller. But before that, some refactoring is done on the existing Leopold controllers. I tried to have the changes logically separated by commit.

Description

  • move fc660c and fc980c under leopold/
    • fc980c is renamed to hasu to make room for the new controller
  • AD5258 driver is deduplicated
  • actuation point adjustment code is deduplicated and reworked
    • actuation point is stored in EEPROM now
  • actuation point example keymap is restored as it has accidentally been dropped in Remove obvious user keymaps, keyboards/{d,e,f}* edition. #22695

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap dd Data Driven Changes labels Sep 9, 2024
@wlhlm
leopold: Deduplicate acuation point adjustment code
65db07d
@wlhlm
leopold: Rework AD5258 driver
b1af195 
Adds I2C error handling.
@wlhlm
leopold: Rework actuation point API
891a3d2
@wlhlm
leopold/fc980c: Revive actuation-point-example keymap
c9a51c1
@wlhlm
leopold/fc980c: Support saving actuation point in QMK EEPROM
4b7e274 
While the AD5258 has its own EEPROM store, we try not to touch it
prevent overwriting the factory value, instead store and load the value
from QMK's EEPROM.
@wlhlm
leopold: Move fc980c into hasu subdir to prepare for addition of new …
cc56d6d 
…controller config
@wlhlm
leopold/fc980c: Move keymaps to keyboard level to share between contr…
f43e93c 
…oller configs

This also replaces the keymaps with versions with prettier formatting.
The actuation point example keymaps is also slightly improved.
@wlhlm
Add support for new STM32-based FC980C controller
568182d
@wlhlm wlhlm force-pushed the new-fc980c-controller-v3 branch from 6828d41 to 568182d Compare September 16, 2024 09:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2024

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dd Data Driven Changes keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wlhlm