Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename saevus to concreteflowers #24249

Merged
merged 5 commits into from
Oct 19, 2024
Merged

Rename saevus to concreteflowers #24249

merged 5 commits into from
Oct 19, 2024

Conversation

ramonimbao
Copy link
Contributor

Description

As part of a rebrand, saevus renamed itself to ConcreteFlowers. This PR updates the boards currently under saevus.

  • keyboards/saevus/cor moved to keyboards/concreteflowers/cor
  • keyboards/saevus/cor_tkl moved to keyboards/concreteflowers/cor_tkl
  • README files updated
  • keyboard.json files updated

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Aug 6, 2024
zvecr
zvecr requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data/mappings/keyboard_aliases.hjson should also be updated to reflect the moved keyboards

@github-actions github-actions bot added the dd Data Driven Changes label Aug 6, 2024
@ramonimbao
Copy link
Contributor Author

Thanks. I've updated the file.,

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 15, 2024
@ramonimbao
Copy link
Contributor Author

Same with #23558, is there anything I need to do for these PRs?

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 17, 2024
@daskygit daskygit merged commit c6b2553 into qmk:develop Oct 19, 2024
3 checks passed
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@ramonimbao @ilham-agustiawan
Rename saevus to concreteflowers (qmk#24249)
d0a0b51
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@ramonimbao @smallketchup82
Rename saevus to concreteflowers (qmk#24249)
566c3a4
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@ramonimbao @jlaptavi
Rename saevus to concreteflowers (qmk#24249)
51e1f38
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@ramonimbao @DmNosachev
Rename saevus to concreteflowers (qmk#24249)
3b51530
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@ramonimbao @SyrupSplashin
Rename saevus to concreteflowers (qmk#24249)
1820904
LeonMusCoden pushed a commit to LeonMusCoden/qmk_firmware that referenced this pull request Jan 5, 2025
@ramonimbao @LeonMusCoden
Rename saevus to concreteflowers (qmk#24249)
8ebf1be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr requested changes

@daskygit daskygit daskygit approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
dd Data Driven Changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramonimbao @drashna @zvecr @daskygit