Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra keymap for EurKEY layout #24241

Merged
merged 4 commits into from
Dec 24, 2024
Merged

Conversation

j-hap
Copy link

@j-hap j-hap commented Aug 4, 2024

Description

QMK contains a keymap_language.h for many OS keyboard layouts. There is non for EurKEY (https://eurkey.steffen.bruentjen.eu/layout.html). Now there is. I used the US Intl as reference, so there are lots of defined, that only change the KC prefix to EU. There are multiple versions of the EurKEY layout. I used 1.2 since 1.3 is marked beta and my current linux seems to contain 1.2.
No custom sendstring.h is needed, because all ASCII is the same as US ANSI.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core documentation dd Data Driven Changes labels Aug 4, 2024
@zvecr zvecr changed the base branch from master to develop August 4, 2024 11:29
@tzarc tzarc added the develop-fast-track Intended to be merged early in the next develop cycle. label Aug 12, 2024
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Sep 27, 2024
@drashna drashna requested review from fauxpark and a team October 3, 2024 00:29
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 3, 2024
@KarlK90
Copy link
Member

KarlK90 commented Oct 6, 2024

Hi @j-hap there are merge conflicts, would mind rebasing your PR?

@j-hap j-hap force-pushed the eurkey-keymap-extra branch from e8871d1 to 746d1ed Compare October 7, 2024 06:13
docs/ChangeLog/20240825.md Outdated Show resolved Hide resolved
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this layout also provides the full set of printable ASCII characters a sendstring LUT should also be added.

@j-hap j-hap requested a review from fauxpark November 7, 2024 05:46
@github-actions github-actions bot added python cli qmk cli command CI labels Dec 5, 2024
@fauxpark
Copy link
Member

fauxpark commented Dec 5, 2024

This PR now has a bad merge commit. Please undo this.

@j-hap j-hap force-pushed the eurkey-keymap-extra branch from 924f1d7 to d9f0603 Compare December 6, 2024 15:40
@j-hap
Copy link
Author

j-hap commented Dec 6, 2024

my bad, i should stop using the sync fork button on anything but master...

@drashna drashna merged commit 38eb643 into qmk:develop Dec 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI cli qmk cli command core dd Data Driven Changes develop-fast-track Intended to be merged early in the next develop cycle. documentation keyboard keymap python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants