Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Reverie to QMK #24227

Merged
merged 13 commits into from
Dec 18, 2024
Merged

Add Reverie to QMK #24227

merged 13 commits into from
Dec 18, 2024

Conversation

awkannan
Copy link
Contributor

@awkannan awkannan commented Aug 1, 2024 •
edited
Loading

Description

Add the Reverie PCB to QMK

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Aug 1, 2024
zvecr
zvecr requested changes Aug 1, 2024
View reviewed changes
keyboards/cannonkeys/reverie/config.h Outdated Show resolved Hide resolved
keyboards/cannonkeys/reverie/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/reverie/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/cannonkeys/reverie/readme.md Outdated

Reverie PCB from CannonKeys

This is for both the solderable and hotswap versions of this PCB. The hotswap version does not support per-key LEDs and has reduced layout support (no ISO)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line implies its 2 different PCBs, so probably should be

keyboards/cannonkeys/reverie/soldered/
keyboards/cannonkeys/reverie/hotswap/

This way it can better encapsulate the hardware differences.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a stab at this - I think its ok now

This was referenced Aug 1, 2024
Merged
Open
dunk2k
dunk2k suggested changes Aug 1, 2024
View reviewed changes
keyboards/cannonkeys/reverie/keyboard.json Outdated Show resolved Hide resolved
@awkannan awkannan requested a review from zvecr August 16, 2024 00:31
drashna
drashna requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

@awkannan
Copy link
Contributor Author

awkannan commented Oct 2, 2024

@drashna I have removed the VIA related stuff and this should be ready to check now

@drashna drashna requested a review from a team October 11, 2024 03:11
@awkannan
Copy link
Contributor Author

awkannan commented Nov 1, 2024

This one is ready for further review
@drashna @fauxpark

Thanks for the feedback so far!

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 18, 2024
@waffle87 waffle87 merged commit c988584 into qmk:master Dec 18, 2024
3 checks passed
dpnetca pushed a commit to dpnetca/qmk_firmware that referenced this pull request Dec 22, 2024
@awkannan @waffle87 @dpnetca
Add Reverie to QMK (qmk#24227)
8563462 
* Add Reverie to QMK

* Add backlight to reverie

* Update reverie readme and copyright notices

* Use format json to update keyboard.json formatting

* Update to have solderable and hotswap variants split

* Update copyright noticeS

* JSON formatting updates

* inherit config.h

* fix broken keymap

* Update reverie hs keyboard.json to be accurate

* Update keyboards/cannonkeys/reverie/hotswap/keyboard.json

Co-authored-by: jack <[email protected]>

* Remove VIA keymaps

* Update keymap

---------

Co-authored-by: jack <[email protected]>
matoushybl pushed a commit to matoushybl/qmk_firmware that referenced this pull request Dec 22, 2024
@awkannan @waffle87 @matoushybl
Add Reverie to QMK (qmk#24227)
07cac5e 
* Add Reverie to QMK

* Add backlight to reverie

* Update reverie readme and copyright notices

* Use format json to update keyboard.json formatting

* Update to have solderable and hotswap variants split

* Update copyright noticeS

* JSON formatting updates

* inherit config.h

* fix broken keymap

* Update reverie hs keyboard.json to be accurate

* Update keyboards/cannonkeys/reverie/hotswap/keyboard.json

Co-authored-by: jack <[email protected]>

* Remove VIA keymaps

* Update keymap

---------

Co-authored-by: jack <[email protected]>
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 24, 2024
@awkannan @waffle87 @ilham-agustiawan
Add Reverie to QMK (qmk#24227)
95c3576 
* Add Reverie to QMK

* Add backlight to reverie

* Update reverie readme and copyright notices

* Use format json to update keyboard.json formatting

* Update to have solderable and hotswap variants split

* Update copyright noticeS

* JSON formatting updates

* inherit config.h

* fix broken keymap

* Update reverie hs keyboard.json to be accurate

* Update keyboards/cannonkeys/reverie/hotswap/keyboard.json

Co-authored-by: jack <[email protected]>

* Remove VIA keymaps

* Update keymap

---------

Co-authored-by: jack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@awkannan @drashna @fauxpark @zvecr @waffle87 @dunk2k