Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard] Corne rev4 #24084

Merged
merged 9 commits into from
Oct 6, 2024
Merged

[Keyboard] Corne rev4 #24084

merged 9 commits into from
Oct 6, 2024

Conversation

drashna
Copy link
Member

@drashna drashna commented Jul 9, 2024

Description

Finish up and clean up corne rev4.

Taken primarily from #22676, but includes fix from (and closes) #23840
@foostan

Types of Changes

  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team July 9, 2024 22:39
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 9, 2024
@luc-vocab
Copy link
Contributor

Hi, would it be OK if I helped out on this merge request ? Is it just a matter of fixing the remaining compilation issues on the various crkbd keymaps ?

@luc-vocab
Copy link
Contributor

does this code support the extra keys for keyboards not using the rotary encoders ?

@waffle87
Copy link
Member

Looks like there's also a Rev 4.1 that has some changes that wouldn't work with regular Rev 4.0 PCBs and vice versa.

#define SERIAL_USART_TX_PIN GP12
#define USB_VBUS_PIN GP13
#define SPLIT_HAND_PIN GP21

@waffle87
Copy link
Member

does this code support the extra keys for keyboards not using the rotary encoders ?

@luc-vocab The layout macro(s) do (LAYOUT_split_3xx_3_ex2), but the keys are not mapped to anything for compatibility with other CRKBD revisions. You are welcome to seek further support in the QMK Discord.

@luc-vocab
Copy link
Contributor

I just got a crkbd 4.1 pre-assembled. The default firmware from https://github.com/foostan/crkbd/blob/main/docs/firmware/rev4/firmware_en.md [crkbd_rev4_1_standard_via.uf2](https://github.com/foostan/kbd_firmware/raw/main/keyboards/crkbd/qmk/qmk_firmware/.build/crkbd_rev4_1_standard_via.uf2) works fine with both halves, however when I try to build the "via" keymap from this pull request, using command qmk compile -kb crkbd/rev4 -km via, only one half works at a time, the other half doesn't display any RGB and doesn't respond to key taps.
are there any diagnostics I could provide to help make debugging this easier ?

@luc-vocab
Copy link
Contributor

I was able to build a firmware for a crkbd v4.1 using instructions here: foostan/crkbd#257 but the pull request from drashna didn't work for me, only one half worked. Does this pull request need t obe updated to cover v4.1 ?

@waffle87
Copy link
Member

waffle87 commented Aug 17, 2024

Does this pull request need t obe updated to cover v4.1 ?

Yes, the code in this PR is not compatible with v4.1 PCBs, only v4.0. See my comment above.

@drashna
Copy link
Member Author

drashna commented Aug 17, 2024

Updated with the 4.1 revision code.

@luc-vocab
Copy link
Contributor

Thank you , is there anything else required to get this PR merged ? Or it's just a matter of waiting for a reviewer ?

@drashna
Copy link
Member Author

drashna commented Aug 21, 2024

It's waiting on reviews.

@DaneEvans
Copy link

Tested rev 4.1 on adjacent hardware, my new board used it as a base.
(Testing everything except key mapping and RGB mapping)
Looks fine, seems to work.
Should not be held up.

@waffle87
Copy link
Member

Generally, two collaborator reviews are required for a merge.

@drashna drashna requested a review from a team September 18, 2024 05:01
@tzarc tzarc merged commit c9cd92e into qmk:develop Oct 6, 2024
3 checks passed
@drashna drashna deleted the keyboard/crkbd_rev4 branch October 6, 2024 20:24
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
* [Keyboard] Corne rev4

* Remove unneeded update interval and moved split pin to dd

* Cleanup config and errors

* Move bootmagic config to dd

* Re-add existing configs

* Additional config fixes

* shove off via keymap
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
* [Keyboard] Corne rev4

* Remove unneeded update interval and moved split pin to dd

* Cleanup config and errors

* Move bootmagic config to dd

* Re-add existing configs

* Additional config fixes

* shove off via keymap
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
* [Keyboard] Corne rev4

* Remove unneeded update interval and moved split pin to dd

* Cleanup config and errors

* Move bootmagic config to dd

* Re-add existing configs

* Additional config fixes

* shove off via keymap
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
* [Keyboard] Corne rev4

* Remove unneeded update interval and moved split pin to dd

* Cleanup config and errors

* Move bootmagic config to dd

* Re-add existing configs

* Additional config fixes

* shove off via keymap
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
* [Keyboard] Corne rev4

* Remove unneeded update interval and moved split pin to dd

* Cleanup config and errors

* Move bootmagic config to dd

* Re-add existing configs

* Additional config fixes

* shove off via keymap
LeonMusCoden pushed a commit to LeonMusCoden/qmk_firmware that referenced this pull request Jan 5, 2025
* [Keyboard] Corne rev4

* Remove unneeded update interval and moved split pin to dd

* Cleanup config and errors

* Move bootmagic config to dd

* Re-add existing configs

* Additional config fixes

* shove off via keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants