-
-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keyboard] Corne rev4 #24084
[Keyboard] Corne rev4 #24084
Conversation
Hi, would it be OK if I helped out on this merge request ? Is it just a matter of fixing the remaining compilation issues on the various crkbd keymaps ? |
does this code support the extra keys for keyboards not using the rotary encoders ? |
Looks like there's also a Rev 4.1 that has some changes that wouldn't work with regular Rev 4.0 PCBs and vice versa. #define SERIAL_USART_TX_PIN GP12
#define USB_VBUS_PIN GP13
#define SPLIT_HAND_PIN GP21 |
@luc-vocab The layout macro(s) do ( |
I just got a crkbd 4.1 pre-assembled. The default firmware from https://github.com/foostan/crkbd/blob/main/docs/firmware/rev4/firmware_en.md |
I was able to build a firmware for a crkbd v4.1 using instructions here: foostan/crkbd#257 but the pull request from drashna didn't work for me, only one half worked. Does this pull request need t obe updated to cover v4.1 ? |
Yes, the code in this PR is not compatible with v4.1 PCBs, only v4.0. See my comment above. |
Updated with the 4.1 revision code. |
Thank you , is there anything else required to get this PR merged ? Or it's just a matter of waiting for a reviewer ? |
It's waiting on reviews. |
Tested rev 4.1 on adjacent hardware, my new board used it as a base. |
Generally, two collaborator reviews are required for a merge. |
* [Keyboard] Corne rev4 * Remove unneeded update interval and moved split pin to dd * Cleanup config and errors * Move bootmagic config to dd * Re-add existing configs * Additional config fixes * shove off via keymap
* [Keyboard] Corne rev4 * Remove unneeded update interval and moved split pin to dd * Cleanup config and errors * Move bootmagic config to dd * Re-add existing configs * Additional config fixes * shove off via keymap
* [Keyboard] Corne rev4 * Remove unneeded update interval and moved split pin to dd * Cleanup config and errors * Move bootmagic config to dd * Re-add existing configs * Additional config fixes * shove off via keymap
* [Keyboard] Corne rev4 * Remove unneeded update interval and moved split pin to dd * Cleanup config and errors * Move bootmagic config to dd * Re-add existing configs * Additional config fixes * shove off via keymap
* [Keyboard] Corne rev4 * Remove unneeded update interval and moved split pin to dd * Cleanup config and errors * Move bootmagic config to dd * Re-add existing configs * Additional config fixes * shove off via keymap
* [Keyboard] Corne rev4 * Remove unneeded update interval and moved split pin to dd * Cleanup config and errors * Move bootmagic config to dd * Re-add existing configs * Additional config fixes * shove off via keymap
Description
Finish up and clean up corne rev4.
Taken primarily from #22676, but includes fix from (and closes) #23840
@foostan
Types of Changes
Checklist