Add Ploopyco functions for host state control #23953
Conversation
- Functionality is opt-in via PLOOPY_HOST_LED_CONTROL - Pressing Num lock cycles DPI - Pressing Scroll lock enables Drag Scroll - Enters bootloader when Num, Caps, and Scroll lock are on at the same time - Updated documentation
- Removed Host State control code from keyboard level - Will leave it up to the user to implement it at the user level
t4corun
changed the title
|
Revised PR based on @obosob's Discord comment. Removed keyboard level Host State control. Leave it to the user to implement it at the keymap. Tested on my Ploopy Nano. The previous commit still has the Host state control if that is still desired. |
Agree with obosob. This is something best left implemented at the user level. However the helper functions are a good idea and useful. |
|
Thanks, but credit to @obosob for the idea. I was originally trying to call the ploopyco DRAG_SCROLL from my other QMK boards and was struggling |
|
@drashna Maybe I made a mistake when I created this PR, was I supposed to submit this to qmk:develop? I think this wasn't included in the 0.26 release. Thanks |
|
It should probably go to develop, yeah. But given the parts that it is touching... it may be fine hitting master directly. |
|
Updated the PR to hit develop instead. Will keep this in mind for next time. Thanks again |
- removing whitespace and adding newline at EOF for code consistency
- Per PR Comments updated markdown table formatting removing the formatting the vscode extension puts in
drashna
changed the title
Addressed gap in Ploopy Nano where drag scroll and dpi cannot be accessed at the userspace level. User can now implement Host State Control in their keymap
Description
Extends on the current code base. Drag scroll variable and dpi cycling logic moved into functions so they can be called at the userspace level.
Types of Changes
Issues Fixed or Closed by This PR
N/A
Checklist