Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cutie Club Fidelity Layout Additions #23838

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Cutie Club Fidelity Layout Additions #23838

merged 4 commits into from
Aug 30, 2024

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented May 31, 2024

Description

  1. expand layout selection for those who cannot use VIA
  2. Conform to PR Checklist regarding keyboards with multiple physical layouts

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • correct non-conformity

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 31, 2024
@dunk2k dunk2k changed the title Cutie Club Fidelity Layout Updates Cutie Club Fidelity Layout Additions May 31, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 25, 2024
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Aug 4, 2024
@drashna drashna requested a review from a team August 30, 2024 07:02
@dunk2k dunk2k requested a review from fauxpark August 30, 2024 16:16
@waffle87 waffle87 merged commit dae5e9e into qmk:develop Aug 30, 2024
3 checks passed
@dunk2k dunk2k deleted the fidelity_expand branch August 31, 2024 07:24
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Sep 6, 2024
@dunk2k @waffle87
Cutie Club Fidelity Layout Additions (qmk#23838)
d3af4d4 
* expand layout selection for fidelity

* remove VIA

* format-json
waffle87 pushed a commit to waffle87/qmk_firmware that referenced this pull request Sep 6, 2024
@dunk2k @waffle87
Cutie Club Fidelity Layout Additions (qmk#23838)
0a2a332 
* expand layout selection for fidelity

* remove VIA

* format-json
itsme-zeix pushed a commit to itsme-zeix/qmk_firmware that referenced this pull request Oct 2, 2024
@dunk2k @itsme-zeix
Cutie Club Fidelity Layout Additions (qmk#23838)
5dfda23 
* expand layout selection for fidelity

* remove VIA

* format-json
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@dunk2k @ilham-agustiawan
Cutie Club Fidelity Layout Additions (qmk#23838)
3983281 
* expand layout selection for fidelity

* remove VIA

* format-json
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@dunk2k @smallketchup82
Cutie Club Fidelity Layout Additions (qmk#23838)
62bbea9 
* expand layout selection for fidelity

* remove VIA

* format-json
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@dunk2k @jlaptavi
Cutie Club Fidelity Layout Additions (qmk#23838)
ebc7b3d 
* expand layout selection for fidelity

* remove VIA

* format-json
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@dunk2k @DmNosachev
Cutie Club Fidelity Layout Additions (qmk#23838)
3f8acb0 
* expand layout selection for fidelity

* remove VIA

* format-json
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@dunk2k @SyrupSplashin
Cutie Club Fidelity Layout Additions (qmk#23838)
91ffc31 
* expand layout selection for fidelity

* remove VIA

* format-json
LeonMusCoden pushed a commit to LeonMusCoden/qmk_firmware that referenced this pull request Jan 5, 2025
@dunk2k @LeonMusCoden
Cutie Club Fidelity Layout Additions (qmk#23838)
55f8f55 
* expand layout selection for fidelity

* remove VIA

* format-json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunk2k @drashna @fauxpark @waffle87