-
-
Notifications
You must be signed in to change notification settings - Fork 40.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chew mono #23835
Add Chew mono #23835
Conversation
keyboards/chew_mono/rules.mk
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you remove this file as it is no longer required.
keyboards/chew_mono/info.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename this file to keyboard.json
I've reorganised my folders like that:
I had to rename the .json which is in the root folder in info.json otherwise it doesn't compile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be targeting develop, since it's a change/migrate,
Also, this really should have a mapping, so that qmk compile -kb chew
will operate correctly for those that have already created configs.
Thank you for your contribution! |
Thank you for your contribution! |
This has some merge conflicts that need resolving. |
They are due to the new sub folders that I've created. |
Thank you for your contribution! |
Thank you for your contribution! |
Is there anything that I can change to validate this PR ? |
b4318cd
to
6805703
Compare
Description
Hello,
This is the unsplitted version of my chew keyboard.
A 34 keys with a RP2040 zero.
You can see the repo with all information here.
Thank you 🚀
Types of Changes
Issues Fixed or Closed by This PR
Checklist