Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a keyboard entry for yacobo model m replacement control boards #23827

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Add a keyboard entry for yacobo model m replacement control boards #23827

merged 6 commits into from
Dec 3, 2024

Conversation

sje-mse
Copy link
Contributor

@sje-mse sje-mse commented May 30, 2024 •
edited
Loading

Adds the "yacobo" firmware for the board found here: https://github.com/sje-mse/yacobo
"Yet Another COntrol BOard" for ibm model m. Similar to Model H, emphasis on use of the blue pill and through-hole components.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 requested changes May 30, 2024
View reviewed changes
Copy link
Member

@waffle87 waffle87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request template is present for a reason. Please fill it out in the future.

keyboards/ibm/model_m/yacobo/keyboard.json Outdated Show resolved Hide resolved
keyboards/ibm/model_m/yacobo/keymaps/default/readme.md Outdated Show resolved Hide resolved
keyboards/ibm/model_m/yacobo/keymaps/sje/keymap.c Outdated Show resolved Hide resolved
keyboards/ibm/model_m/yacobo/readme.md Show resolved Hide resolved
keyboards/ibm/model_m/yacobo/yacobo.c Outdated Show resolved Hide resolved
@sje-mse
Copy link
Contributor Author

sje-mse commented May 30, 2024

The pull request template is present for a reason. Please fill it out in the future.

My apologies, I misread it as optional. I'll restore it.

@sje-mse sje-mse changed the title add the keyboard Add a keyboard entry for yacobo model m replacement control boards May 30, 2024
@sje-mse sje-mse requested a review from waffle87 May 30, 2024 12:34
dunk2k
dunk2k suggested changes May 30, 2024
View reviewed changes
keyboards/ibm/model_m/yacobo/keyboard.json Outdated Show resolved Hide resolved
keyboards/ibm/model_m/yacobo/keyboard.json Outdated Show resolved Hide resolved
keyboards/ibm/model_m/yacobo/readme.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 15, 2024
@drashna drashna requested a review from a team July 15, 2024 04:17
@drashna drashna removed the stale Issues or pull requests that have become inactive without resolution. label Jul 15, 2024
@sje-mse sje-mse requested a review from dunk2k August 25, 2024 23:34
@sje-mse
Copy link
Contributor Author

sje-mse commented Aug 25, 2024

@waffle87 Thanks for your comments. It's taken me a while to get back to this but I believe I've addressed your concerns.

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 10, 2024
@sje-mse
Copy link
Contributor Author

sje-mse commented Oct 10, 2024

I think this is ready to be re-assessed.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 12, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 26, 2024
@sje-mse
Copy link
Contributor Author

sje-mse commented Dec 3, 2024

Bump! I believe this is ready to be re-assessed.

@waffle87 waffle87 merged commit 85222df into qmk:master Dec 3, 2024
3 checks passed
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 5, 2024
@sje-mse @waffle87 @ilham-agustiawan
Add a keyboard entry for yacobo model m replacement control boards (q…
c42837d 
…mk#23827)

* add the keyboard

* Update keyboards/ibm/model_m/yacobo/keyboard.json

Co-authored-by: jack <[email protected]>

* remove dead file

* PR Comments

* standardize comments

* PR Comments

---------

Co-authored-by: Stephen Edwards <[email protected]>
Co-authored-by: jack <[email protected]>
@sje-mse sje-mse deleted the add-yacobo-keyboard branch December 5, 2024 15:15
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@sje-mse @waffle87 @DmNosachev
Add a keyboard entry for yacobo model m replacement control boards (q…
7d04264 
…mk#23827)

* add the keyboard

* Update keyboards/ibm/model_m/yacobo/keyboard.json

Co-authored-by: jack <[email protected]>

* remove dead file

* PR Comments

* standardize comments

* PR Comments

---------

Co-authored-by: Stephen Edwards <[email protected]>
Co-authored-by: jack <[email protected]>
eliseomartelli pushed a commit to eliseomartelli/qmk_firmware that referenced this pull request Dec 9, 2024
@sje-mse @waffle87 @eliseomartelli
Add a keyboard entry for yacobo model m replacement control boards (q…
4015378 
…mk#23827)

* add the keyboard

* Update keyboards/ibm/model_m/yacobo/keyboard.json

Co-authored-by: jack <[email protected]>

* remove dead file

* PR Comments

* standardize comments

* PR Comments

---------

Co-authored-by: Stephen Edwards <[email protected]>
Co-authored-by: jack <[email protected]>
waffle87 added a commit to waffle87/qmk_firmware that referenced this pull request Dec 10, 2024
@sje-mse @waffle87
Add a keyboard entry for yacobo model m replacement control boards (q…
fed557e 
…mk#23827)

* add the keyboard

* Update keyboards/ibm/model_m/yacobo/keyboard.json

Co-authored-by: jack <[email protected]>

* remove dead file

* PR Comments

* standardize comments

* PR Comments

---------

Co-authored-by: Stephen Edwards <[email protected]>
Co-authored-by: jack <[email protected]>
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@sje-mse @waffle87 @SyrupSplashin
Add a keyboard entry for yacobo model m replacement control boards (q…
85dd135 
…mk#23827)

* add the keyboard

* Update keyboards/ibm/model_m/yacobo/keyboard.json

Co-authored-by: jack <[email protected]>

* remove dead file

* PR Comments

* standardize comments

* PR Comments

---------

Co-authored-by: Stephen Edwards <[email protected]>
Co-authored-by: jack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

@dunk2k dunk2k Awaiting requested review from dunk2k

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sje-mse @drashna @waffle87 @dunk2k