Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data-Driven Keyboard Conversions: M, Part 3 #23614

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Data-Driven Keyboard Conversions: M, Part 3 #23614

merged 1 commit into from
Apr 26, 2024

Conversation

noroadsleft
Copy link
Member

Description

Converts rules.mk entries to data-driven where applicable. Renames info.json to keyboard.json in instances where rules.mk can be safely deleted.

  • keyboards with names beginning with m[f-z]

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
Data-Driven Keyboard Conversions: M, Part 3
95115c9 
Converts `rules.mk` entries to data-driven where applicable. Renames
`info.json` to `keyboard.json` in instances where `rules.mk` can be
safely deleted.

Affects:

  - `mitosis`
  - `mlego/m60_split/rev1`
  - `mlego/m60_split/rev2`
  - `molecule`
  - `monokei/mnk1800s`
  - `monokei/mnk50`
  - `monokei/mnk75`
  - `montsinger/rebound/rev1`
  - `montsinger/rebound/rev2`
  - `montsinger/rebound/rev3`
  - `montsinger/rebound/rev4`
  - `moon`
  - `mt/ncr80/hotswap`
  - `mt/ncr80/solder`
  - `mt/split75`
@noroadsleft noroadsleft requested review from zvecr and a team April 25, 2024 19:16
@zvecr zvecr merged commit 42f6161 into qmk:develop Apr 26, 2024
2 of 3 checks passed
@noroadsleft noroadsleft deleted the dev/dd_json_m3 branch April 26, 2024 05:35
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@noroadsleft @whoisjordangarcia
Data-Driven Keyboard Conversions: M, Part 3 (qmk#23614)
878ac18
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@noroadsleft @nuess0r
Data-Driven Keyboard Conversions: M, Part 3 (qmk#23614)
0223075
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@noroadsleft @Ardakilic
Data-Driven Keyboard Conversions: M, Part 3 (qmk#23614)
2212eb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @fauxpark @zvecr