Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WAIT_FOR_USB handling #23598

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Fix WAIT_FOR_USB handling #23598

merged 2 commits into from
Apr 24, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 24, 2024 •
edited
Loading

Description

Not sure if/when this was broken, but only the config.h version would actually do anything.

usb.wait_for has been renamed to usb.wait_for_enumeration to better reflect the functionality. Backwards compatibility of the underlying define has been added, but not for .json as it has never worked.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Apr 24, 2024
@fauxpark
Copy link
Member

usb.wait_for_enumeration/USB_WAIT_FOR_ENUMERATION perhaps.

@zvecr zvecr requested a review from a team April 24, 2024 05:54
@zvecr zvecr merged commit 16cca52 into develop Apr 24, 2024
4 of 5 checks passed
@zvecr zvecr deleted the fix_usb_wait_for branch April 24, 2024 18:33
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @whoisjordangarcia
Fix WAIT_FOR_USB handling (qmk#23598)
7fd3def
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Fix WAIT_FOR_USB handling (qmk#23598)
a854fe5
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@zvecr @Ardakilic
Fix WAIT_FOR_USB handling (qmk#23598)
0351f6a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug core dd Data Driven Changes documentation keyboard translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark