Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data-Driven Keyboard Conversions: M, Part 1 #23590

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Data-Driven Keyboard Conversions: M, Part 1 #23590

merged 1 commit into from
Apr 23, 2024

Conversation

noroadsleft
Copy link
Member

Description

Converts rules.mk entries to data-driven where applicable. Renames info.json to keyboard.json in instances where rules.mk can be safely deleted.

  • keyboards with names beginning with ma

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft
Data-Driven Keyboard Conversions: M, Part 1
0e25de1 
Converts `rules.mk` entries to data-driven where applicable. Renames
`info.json` to `keyboard.json` in instances where `rules.mk` can be
safely deleted.

Affects:

  - `malevolti/lyra/rev1`
  - `maple_computing/christmas_tree/v2017`
  - `maple_computing/ivy/rev1`
  - `maple_computing/jnao`
  - `maple_computing/launchpad/rev1`
  - `maple_computing/lets_split_eh/eh`
  - `maple_computing/minidox/rev1`
  - `marksard/rhymestone/rev1`
  - `marksard/treadstone48/rev1`
  - `marksard/treadstone48/rev2`
  - `massdrop/alt`
  - `massdrop/ctrl`
  - `matrix/abelx`
  - `matrix/m12og/rev1`
  - `matrix/m20add`
  - `matrix/noah`
@noroadsleft noroadsleft requested review from zvecr and a team April 23, 2024 01:53
@zvecr zvecr merged commit a1cbdf1 into qmk:develop Apr 23, 2024
1 of 3 checks passed
@noroadsleft noroadsleft deleted the dev/dd_json_m1 branch April 23, 2024 23:43
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@noroadsleft @whoisjordangarcia
Data-Driven Keyboard Conversions: M, Part 1 (qmk#23590)
1abd3b5
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@noroadsleft @nuess0r
Data-Driven Keyboard Conversions: M, Part 1 (qmk#23590)
dd80891
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@noroadsleft @Ardakilic
Data-Driven Keyboard Conversions: M, Part 1 (qmk#23590)
15c158c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @fauxpark @zvecr