Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename RGBW define to WS2812_RGBW #23585

Merged
merged 2 commits into from
Apr 27, 2024
Merged

Conversation

fauxpark
Copy link
Member

Description

This define really only affects the WS2812 driver:

  • RGBLight only supports WS2812 and APA102 LEDs. As far as I can ascertain, there is no such thing as an RGBW APA102, and there is no support for RGBW in the current APA102 driver code.
  • RGB Matrix supports WS2812 as well as a variety of ISSI LED drivers. These technically could do RGBW, as the drivers are simply mapping the RGB values to the PWM buffer indices specified in their LED config structs, but I would argue these should get their own defines (eg. IS31FL3733_RGBW etc.), if there exists a board with RGBW LEDs driven by one of these chips.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 22, 2024 10:35
@fauxpark fauxpark merged commit 0ff53b2 into qmk:develop Apr 27, 2024
3 of 5 checks passed
@fauxpark fauxpark deleted the ws2812-rgbw-define branch April 27, 2024 14:36
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants