Data-Driven Keyboard Conversions: K, Part 3 #23566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
Apr 20, 2024
Converts `rules.mk` entries to data-driven where applicable. Renames `info.json` to `keyboard.json` in instances where `rules.mk` can be safely deleted. Affects: - `keebformom` - `keebio/bdn9/rev1` - `keebio/bdn9/rev2` - `keebio/dsp40/rev1` - `keebio/foldkb/rev1` - `keebio/iris/rev2` - `keebio/iris/rev3` - `keebio/iris/rev4` - `keebio/iris/rev6` - `keebio/iris/rev7` - `keebio/kbo5000/rev1` - `keebio/levinson/rev1` - `keebio/levinson/rev2` - `keebio/levinson/rev3` - `keebio/quefrency/rev1` - `keebio/quefrency/rev2` - `keebio/quefrency/rev3` - `keebio/quefrency/rev4` - `keebio/quefrency/rev5` - `keebio/rorschach/rev1` - `keebio/viterbi/rev1` - `keebio/viterbi/rev2` - `keebio/wavelet` - `keebwerk/mega/ansi` - `keebwerk/nano_slider`
noroadsleft
force-pushed
the
dev/dd_json_k3
branch
from
d73165c to
e464e64
Compare
|
Someday I'll learn to lint after rebasing... 🤦♂️ |
zvecr
approved these changes
Apr 22, 2024
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Ardakilic
pushed a commit
to Ardakilic/qmk_firmware
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts
rules.mkentries to data-driven where applicable. Renamesinfo.jsontokeyboard.jsonin instances whererules.mkcan be safely deleted.ke[a-e]Types of Changes
Checklist