Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data-driven Keyboard Conversions: C #23453

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

noroadsleft
Copy link
Member

Description

Converts rules.mk entries to data-driven where applicable. Renames info.json to keyboard.json in instances where rules.mk can be safely deleted.

  • keyboards with names beginning with c

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Converts `rules.mk` entries to data-driven where applicable. Renames
`info.json` to `keyboard.json` in instances where `rules.mk` can be
safely deleted.

Affects:

  - `cannonkeys/aella`
  - `cannonkeys/an_c`
  - `cannonkeys/balance`
  - `cannonkeys/brutalv2_65`
  - `cannonkeys/cloudline`
  - `cannonkeys/crin`
  - `cannonkeys/db60`
  - `cannonkeys/devastatingtkl`
  - `cannonkeys/gentoo`
  - `cannonkeys/gentoo_hs`
  - `cannonkeys/instant60`
  - `cannonkeys/instant65`
  - `cannonkeys/malicious_ergo`
  - `cannonkeys/obliterated75`
  - `cannonkeys/onyx`
  - `cannonkeys/rekt1800`
  - `cannonkeys/sagittarius`
  - `cannonkeys/savage65`
  - `cannonkeys/tmov2`
  - `cannonkeys/tsukuyomi`
  - `cannonkeys/vicious40`
  - `centromere`
  - `checkerboards/phoenix45_ortho`
  - `checkerboards/quark`
  - `checkerboards/quark_squared`
  - `checkerboards/snop60`
  - `chlx/str_merro60`
  - `cipulot/kawayo`
  - `clueboard/66_hotswap/prototype`
  - `coarse/ixora`
  - `coarse/vinta`
  - `controllerworks/city42`
  - `converter/adb_usb`
  - `converter/hp_46010a`
  - `converter/ibm_terminal`
  - `converter/m0110_usb`
  - `converter/palm_usb`
  - `converter/periboard_512`
  - `converter/siemens_tastatur`
  - `converter/sun_usb`
  - `converter/xt_usb`
  - `coseyfannitutti/discipline`
  - `coseyfannitutti/mysterium`
  - `cozykeys/speedo/v3`
  - `crimsonkeyboards/resume1800`
  - `crypt_macro`
  - `custommk/genesis`
@noroadsleft
Copy link
Member Author

CI Build Failure:

Failed: checkerboards/snop60:via

Copying checkerboards_snop60_via.hex to qmk_firmware folder                                         [OK]
Checking file size of checkerboards_snop60_via.hex
 * The firmware is too large! 28988/28672 (316 bytes over)

@fauxpark
Copy link
Member

Looks like that board previously had ENCODER_ENBALE = yes instead of ENABLE.

@zvecr zvecr merged commit a532d1c into qmk:develop Apr 11, 2024
2 of 3 checks passed
@noroadsleft noroadsleft deleted the dev/dd_json_c branch April 12, 2024 03:27
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants