Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail if config.h-migrateable entities aren't in keyboard.json. #23449

Closed
wants to merge 2 commits into from

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Apr 10, 2024

Description

Now that the config.h ordering has been somewhat sorted (#23448, keyboard before generated info_config.h before keymap), this will ensure that if there are keyboard-level items in config.h cause failures during build, prompting migration.

Additionally, a large chunk of documentation will need to be migrated away from promoting the use of config.h before we could consider merging this.

This is raised early for visibility purposes and is not expected to be merged any time soon; almost all migrations will need to occur first, otherwise there will be hundreds of build failures.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team April 10, 2024 10:05
@github-actions github-actions bot added python cli qmk cli command labels Apr 10, 2024
@tzarc tzarc changed the title Fail if migrated entities aren't migrated. Fail if config.h-migrateable entities aren't in keyboard.json. Apr 10, 2024
@tzarc tzarc closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant