Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MCU support for ArteryTek AT32F415 #23445

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

HorrorTroll
Copy link
Contributor

@HorrorTroll HorrorTroll commented Apr 9, 2024

Description

This PR is added support for AT32F415 to QMK.

Driver:

Click to expand!
System Support
ADC driver ✔️
Audio ✔️ (using PWM software or hardware, since MCU don't support DAC)
Backlight ✔️ (using PWM, Timer and Software)
I2C driver ✔️
SPI driver ✔️
WS2812 driver ✔️ (using Bitbang, SPI or PWM driver)
External EEPROMs ✖️
EEPROM emulation ✔️
serial driver ✔️ (using Full-duplex (1))
UART driver ❗ (already tested on ChibiOS code, should be work here too)

Notes:

  • (1): Half-duplex is not tested.
  • ✖️ is meant for not testing either, since I don't have any hardware to try them.

Handwired Onekey:

Click to expand!
Keymap Testing
adc ✔️
apa102 ✖️
backlight ✔️
chibios_waiting_test ❗ (need Logic Analyzer)
console ✔️
default ✔️
digitizer ✖️
dip_switch_map ✖️
eep_rst ✔️
haptic ✖️
hardware_id ✔️
i2c_scanner ✔️
joystick ✖️
lvgl ✖️ (not enough flash)
oled ✔️
quine ✔️
reboot ✔️
reset ✔️
rgb ✔️
wear_leveling ✔️

Notes:

  • ✖️ is meant for not testing, since I don't have any hardware to try them.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core keyboard documentation python cli qmk cli command dd Data Driven Changes labels Apr 9, 2024
@drashna drashna requested a review from a team May 1, 2024 06:52
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 16, 2024
@HorrorTroll
Copy link
Contributor Author

Still on hold for waiting preview, thanks.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 17, 2024
Copy link

github-actions bot commented Aug 1, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Aug 1, 2024
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a number of lint/formatting issues, but otherwise, lgtm.

@HorrorTroll
Copy link
Contributor Author

I've just update backlight driver support and fixed lint formatting. If anyone have time, feel free to checkout again. Thanks!

@tzarc
Copy link
Member

tzarc commented Aug 13, 2024

Have asked a couple of members of the team to pick up AT-START-F415's for validation purposes.

docs/flashing.md Outdated Show resolved Hide resolved
* Added support for new AT32F415 MCU

* Added Generic AT32F415 board

* Added document of flashing and bootloader for new MCU

* Added support wear leveling driver

* Added support SPI driver

* Added support WS2812 driver

* Added support Serial driver

* Added support ADC driver

* Added AT-START-F415 onekey
@MHooijberg
Copy link

Hi,

Is there anything I can do to help speed up the process, maybe work making the QMK CI Build action pass?
Or is this PR currently just waiting on review?

Thanks.

@HorrorTroll
Copy link
Contributor Author

Hi,

Is there anything I can do to help speed up the process, maybe work making the QMK CI Build action pass? Or is this PR currently just waiting on review?

Thanks.

Hi, I really appreciate that you want for help. I was reading your mail recently.

Right now the PR is waiting for review from QMK collaboration, so it might take time for them.

@MHooijberg
Copy link

Hi,
Is there anything I can do to help speed up the process, maybe work making the QMK CI Build action pass? Or is this PR currently just waiting on review?
Thanks.

Hi, I really appreciate that you want for help. I was reading your mail recently.

Right now the PR is waiting for review from QMK collaboration, so it might take time for them.

Alright,
if you do need anything, I have a keyboard that uses this chip.

I'll wait on QMK and start working on a keyboard branch then.
Thanks again, also thanks for all the work done for adding this MCU family.

@drashna drashna requested a review from a team October 20, 2024 02:56
@drashna drashna removed the stale Issues or pull requests that have become inactive without resolution. label Oct 20, 2024
@drashna
Copy link
Member

drashna commented Oct 20, 2024

A few of the one-key builds are failing. While not critical, it would be nice to have them passing.

  • APA102 config is wrong/missing.
  • SOLENOID_PIN(S) isn't defined
  • SPI peripheral not configured for lvgl keymap

@tzarc tzarc merged commit 39161b9 into qmk:develop Nov 21, 2024
7 of 8 checks passed
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants