Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oneshot locked mods split transaction #23434

Merged

Conversation

NoOne2246
Copy link
Contributor

@NoOne2246 NoOne2246 commented Apr 7, 2024

Split transaction mods does not transfer one shot locked mods.

Description

As noted in the title, split transactions one shot locked mods is not transferred to slave side for oled display, this pull request aims to change that.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

NoOne2246 and others added 3 commits April 7, 2024 23:32
Add oneshot locked mods to mods transferred
Add oneshot locked mods to transfer protocol
@drashna drashna requested a review from a team April 8, 2024 16:22
@waffle87 waffle87 merged commit b99143f into qmk:develop Apr 8, 2024
4 checks passed
@NoOne2246 NoOne2246 deleted the Feature-Oneshot-locked-mods-split-transaction branch April 8, 2024 20:35
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants