Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing keyboards on develop #23406

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fix failing keyboards on develop #23406

merged 1 commit into from
Apr 3, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 3, 2024 •
edited
Loading

Description

https://github.com/qmk/qmk_firmware/pull/23405/checks?check_run_id=23385807776

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team April 3, 2024 12:36
@zvecr zvecr added the bug label Apr 3, 2024
@zvecr zvecr merged commit 62af50c into develop Apr 3, 2024
2 of 3 checks passed
@zvecr zvecr deleted the misc_kb_fixes2 branch April 3, 2024 13:01
@fauxpark fauxpark mentioned this pull request Apr 3, 2024
Merged
14 tasks
dunk2k added a commit to dunk2k/qmk_firmware that referenced this pull request Apr 3, 2024
@dunk2k
post qmk#23406 additions
56511cf
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @whoisjordangarcia
Fix failing keyboards on develop (qmk#23406)
8fa4ffb
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Fix failing keyboards on develop (qmk#23406)
792d7f9
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@zvecr @Ardakilic
Fix failing keyboards on develop (qmk#23406)
f9e5162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @fauxpark