Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0xcb/splaytoraid: remove CONVERT_TO at keyboard level #23395

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 2, 2024

Description

Configurator/api_tasks cannot handle converted boards, resulting in the following on the status page:

Ψ Compiling keymap with gmake -r -R -f builddefs/build_keyboard.mk -s KEYBOARD=0xcb/splaytoraid/rp2040_ce KEYMAP=default_configurator KEYBOARD_FILESAFE=0xcb_splaytoraid_rp2040_ce TARGET=0xcb_splaytoraid_rp2040_ce_default_configurator INTERMEDIATE_OUTPUT=.build/obj_0xcb_splaytoraid_rp2040_ce_default_configurator VERBOSE=false COLOR=true SILENT=false QMK_BIN="qmk" MAIN_KEYMAP_PATH_1=.build/obj_0xcb_splaytoraid_rp2040_ce_default_configurator MAIN_KEYMAP_PATH_2=.build/obj_0xcb_splaytoraid_rp2040_ce_default_configurator MAIN_KEYMAP_PATH_3=.build/obj_0xcb_splaytoraid_rp2040_ce_default_configurator MAIN_KEYMAP_PATH_4=.build/obj_0xcb_splaytoraid_rp2040_ce_default_configurator MAIN_KEYMAP_PATH_5=.build/obj_0xcb_splaytoraid_rp2040_ce_default_configurator KEYMAP_JSON=.build/obj_0xcb_splaytoraid_rp2040_ce_default_configurator/src/keymap.json KEYMAP_PATH=.build/obj_0xcb_splaytoraid_rp2040_ce_default_configurator/src


platforms/chibios/platform.mk:266: lib/chibios/os/hal/lib/streams/streams.mk: No such file or directory
gmake: *** No rule to make target 'lib/chibios/os/hal/lib/streams/streams.mk'.  Stop.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr merged commit 0573120 into qmk:develop Apr 2, 2024
3 checks passed
@fauxpark fauxpark deleted the splaytoraid-remove-converter branch April 2, 2024 14:39
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants