Fix pointing_device_set_cpi_on_side() changing CPI on correct side. relevant to #19433. #23391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesshonor
reviewed
Apr 1, 2024
Co-authored-by: Less/Rikki <[email protected]>
|
Good catch, I wonder why I over complicated this. Anyways thanks, I think this can probably target master as a bug fix. Surprised no one has caught this before. |
daskygit
approved these changes
Apr 1, 2024
lesshonor
approved these changes
Apr 2, 2024
drashna
approved these changes
Apr 4, 2024
mzyt
pushed a commit
to mzyt/qmk_firmware
that referenced
this pull request
May 6, 2024
Co-authored-by: Less/Rikki <[email protected]>
IvanJackson
pushed a commit
to IvanJackson/qmk_firmware
that referenced
this pull request
May 6, 2024
Co-authored-by: Less/Rikki <[email protected]>
girtsf
pushed a commit
to girtsf/qmk_firmware
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Less/Rikki <[email protected]>
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
Co-authored-by: Less/Rikki <[email protected]>
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Co-authored-by: Less/Rikki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrected that when the USB cable was on the right side, the left side was changed when trying to change the CPI on the right side in POINTING_DEVICE_CONBINED.
Types of Changes
Issues Fixed or Closed by This PR
Checklist