Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rgblight init #23335

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Fix rgblight init #23335

merged 1 commit into from
Mar 24, 2024

Conversation

daskygit
Copy link
Member

Description

Bug reported in discord by @lesshonor

Fixes an issue introduced by #23076, rgblight_mode_noeeprom was trying to set_leds before init had happened.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Mar 24, 2024
@tzarc tzarc merged commit d0ee4a1 into qmk:develop Mar 24, 2024
4 checks passed
@tzarc tzarc added the bug label Mar 24, 2024
@daskygit daskygit deleted the fix/rgblight_init branch March 24, 2024 00:25
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@daskygit @whoisjordangarcia
Fix rgblight init (qmk#23335)
7719b52
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@daskygit @nuess0r
Fix rgblight init (qmk#23335)
ecba644
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@daskygit @Ardakilic
Fix rgblight init (qmk#23335)
205fa5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daskygit @tzarc