Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-extern RGBLight led[] array #23322

Merged
merged 8 commits into from
Mar 22, 2024
Merged

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Mar 21, 2024

Description

Keyboard and keymap code should use the existing RGBLight API to manipulate the LEDs instead of directly modifying the array.

I expect CI to reveal a bunch of issues here as there are still some boards which are doing so.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 21, 2024 06:17
@zvecr
Copy link
Member

zvecr commented Mar 22, 2024

hineybush/hbcp:hiney is failing due to use of the removed content.

Keymap itself doesnt seem to add a whole lot of value. My preference is just to remove it as a "user" keymap.

@zvecr zvecr merged commit 583cde3 into qmk:develop Mar 22, 2024
5 checks passed
@fauxpark fauxpark deleted the un-extern-rgblight-array branch March 22, 2024 06:21
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants