Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to PR Checklist #23318

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Updates to PR Checklist #23318

merged 1 commit into from
Mar 20, 2024

Conversation

waffle87
Copy link
Member

Description

Some small changes to pr_checklist.md discouraging frequent branch updating for sake of CI, remove Imgur suffix requirement as they seem to be deprecated by Imgur, and some other things.

Types of Changes

  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87 waffle87 requested a review from a team March 20, 2024 14:39
@waffle87 waffle87 merged commit 53f4689 into qmk:master Mar 20, 2024
2 checks passed
@waffle87 waffle87 deleted the doc/pr_chklst branch March 20, 2024 15:09
dlip added a commit to dlip/qmk_firmware that referenced this pull request Mar 21, 2024
* upstream/master: (40 commits)
  [Keyboard] Add marshkeys flowerpad (qmk#23240)
  Add TechnicPad macropad (qmk#23238)
  Add handwired/Jotlily60 (qmk#23212)
  Add the EQUATOR keyboard (qmk#23237)
  Support for slice65 from PizzaKeyboards (qmk#23148)
  Add Swiss support (qmk#23272)
  Assume only 32u4 boards can run 'promicro' converters (qmk#23312)
  Add Macropad 6Pad (qmk#23099)
  Fix invalid use of stemcell converter (qmk#23317)
  Updates to PR Checklist (qmk#23318)
  [Keyboard] Add posey_split v4/v5 (qmk#23258)
  Added WT65-H3 (HIBI HIBIKI) (qmk#22886)
  Added WT65-G3 (HIBI HIBIKI) (qmk#22888)
  Modify wording in 'getting_started_introduction.md' (qmk#23232)
  Bump tj-actions/changed-files from 42 to 43 (qmk#23282)
  AMJKeyboard AMJ96 Layout Additions (qmk#23267)
  Fixup cipulot eeprom. (qmk#23280)
  Update feature_tri_layer.md - typo (qmk#23275)
  [Keyboard] add glyphkbd_v2 (qmk#23131)
  Add support new kb_elmo PCBs (qmk#23138)
  ...
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants