Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ares Layout Additions #23254

Merged
merged 11 commits into from
Mar 12, 2024
Merged

Ares Layout Additions #23254

merged 11 commits into from
Mar 12, 2024

Conversation

noroadsleft
Copy link
Member

Description

  • adds seven new layouts
  • adds layout/matrix diagram
  • extends Community Layout support

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team March 10, 2024 08:15
dunk2k
dunk2k suggested changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@dunk2k dunk2k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include 60*wkl* Community Layouts

keyboards/ares/info.json Outdated Show resolved Hide resolved
keyboards/ares/info.json Show resolved Hide resolved
keyboards/ares/info.json Show resolved Hide resolved
dunk2k added a commit to dunk2k/qmk_firmware that referenced this pull request Mar 10, 2024
@dunk2k
revert ares in favour of qmk#23254
1790563
@noroadsleft
Add 60*wkl* layouts per dunk2k
98cf754 
- Add:
  - `LAYOUT_60_ansi_wkl`
  - `LAYOUT_60_ansi_wkl_split_bs_rshift`
  - `LAYOUT_60_iso_wkl`
  - `LAYOUT_60_iso_wkl_split_bs_rshift`
- update matrix diagram

[enhancement]
@noroadsleft
Update Community Layout support
9e4fe7a 
[enhancement]
@noroadsleft noroadsleft requested a review from dunk2k March 10, 2024 20:40
@drashna drashna merged commit 3a3b4d1 into qmk:master Mar 12, 2024
3 checks passed
@noroadsleft noroadsleft deleted the cf/ares branch March 13, 2024 05:06
mzyt pushed a commit to mzyt/qmk_firmware that referenced this pull request May 6, 2024
@noroadsleft
Ares Layout Additions (qmk#23254)
911bf8d
girtsf pushed a commit to girtsf/qmk_firmware that referenced this pull request Jun 5, 2024
@noroadsleft @girtsf
Ares Layout Additions (qmk#23254)
358110a
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@noroadsleft @whoisjordangarcia
Ares Layout Additions (qmk#23254)
43c2404
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@noroadsleft @nuess0r
Ares Layout Additions (qmk#23254)
a6a0083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noroadsleft @drashna @fauxpark @dunk2k