LED drivers: add support for shutdown pin #23058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Long overdue...
This adds support for specifying a pin to set as output high connected to the
SDB
pin of the LED driver(s), which should eliminate a small bit of code at the keyboard level for those boards which do not simply have it tied to VCC.Note that only one pin is supported, as if you have multiple drivers on a board it seems unlikely you would want to control them independently. The AW20216S driver does this but as far as I can tell every board currently in the repo which uses it uses the same pin for both defines, so I will probably rework that in future.
This is also a very basic implementation to start with - all it does is set the pin high during
init_drivers()
; there is currently no logic to toggle the SDB signal when the board suspends/wakes, but this could be added later.Types of Changes
Issues Fixed or Closed by This PR
Checklist