Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joystick initialization #22953

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix joystick initialization #22953

merged 1 commit into from
Feb 16, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 24, 2024

Description

Extracted from #22947 to make DD changes cleaner/clearer.

  • output_pin/ground_pin removed
    • Previously planned removal never happened
    • users will now need to override weak init/sample functions
  • Correctly inits joystick_axes to virtual when no config
    • input_pin would equal zero which is a valid value on chibios platforms (eg rp2040)
  • Correct handling of input_pin as 0xFF is not a valid value to use
    • again could be a valid value on chibios platforms
  • Fixes compilation when JOYSTICK_AXIS_COUNT == 0

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc merged commit 77e8867 into develop Feb 16, 2024
3 of 4 checks passed
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants