Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(keyboard): quokka #22942

Merged
merged 2 commits into from
Jan 23, 2024
Merged

refactor(keyboard): quokka #22942

merged 2 commits into from
Jan 23, 2024

Conversation

lesshonor
Copy link
Contributor

Description

Add x and y coordinates to info.json. Format all files.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Screenshot of the Quokka keyboard in QMK Configurator. All of the keys are on a single line.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@lesshonor
refactor: quokka
65bb33a 
* Add x and y coordinates to info.json and format all files.
dunk2k
dunk2k suggested changes Jan 22, 2024
View reviewed changes
keyboards/quokka/info.json Show resolved Hide resolved
@lesshonor @dunk2k
feat: community layout support
efc07b8 
Co-authored-by: Duncan Sutherland <[email protected]>
@drashna drashna merged commit a62fefe into qmk:develop Jan 23, 2024
3 checks passed
@lesshonor lesshonor deleted the refactor/quokka branch January 23, 2024 02:36
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@lesshonor @dunk2k @nuess0r
refactor (keyboard): quokka (qmk#22942)
f8c2e22 
Co-authored-by: Duncan Sutherland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lesshonor @drashna @zvecr @dunk2k