Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant disabling of features #22926

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Remove redundant disabling of features #22926

merged 1 commit into from
Mar 9, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 19, 2024 •
edited
Loading

Description

Setting a feature to false just makes the info.json more verbose.

Current pass:

  • audio
  • backlight
  • bluetooth
  • midi
  • unicode
  • rgblight

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr force-pushed the tidy_info_features branch from db7f44f to 6bfc5b3 Compare February 2, 2024 00:46
@zvecr zvecr force-pushed the tidy_info_features branch from 6bfc5b3 to 5d393e3 Compare February 20, 2024 22:25
@noroadsleft
Copy link
Member

Oops, there's merge conflicts here. But I like the changeset.

@zvecr zvecr force-pushed the tidy_info_features branch from 5d393e3 to 7fd3ba3 Compare March 9, 2024 01:08
@zvecr zvecr merged commit 58c3817 into develop Mar 9, 2024
1 of 3 checks passed
@zvecr zvecr deleted the tidy_info_features branch March 9, 2024 03:05
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@zvecr @mechlovin
Remove redundant disabling of features (qmk#22926)
28fb04d
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@zvecr @mechlovin
Remove redundant disabling of features (qmk#22926)
f7dd4dd
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
@zvecr @mechlovin
Remove redundant disabling of features (qmk#22926)
8705891
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @whoisjordangarcia
Remove redundant disabling of features (qmk#22926)
524f7bb
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Remove redundant disabling of features (qmk#22926)
33caa22
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@zvecr @Ardakilic
Remove redundant disabling of features (qmk#22926)
0fb91b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @noroadsleft