LED drivers: remove PWM register offsets #22897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Offset should only be applied when actually writing out the buffer. This simplifies assigning PWM values to indices into the buffer as there is no need to subtract the offset first (and three times for R,G,B).
Additionally, some usages of
int
have been changed touint8_t
since they will never be negative nor greater than 255.Lastly the +1 offset was removed from the 3742A driver; its PWM registers start at 0x00 unlike the other ex-IS31COMMON drivers.
Types of Changes
Issues Fixed or Closed by This PR
Checklist