Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED drivers: remove PWM register offsets #22897

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

fauxpark
Copy link
Member

Description

Offset should only be applied when actually writing out the buffer. This simplifies assigning PWM values to indices into the buffer as there is no need to subtract the offset first (and three times for R,G,B).

Additionally, some usages of int have been changed to uint8_t since they will never be negative nor greater than 255.

Lastly the +1 offset was removed from the 3742A driver; its PWM registers start at 0x00 unlike the other ex-IS31COMMON drivers.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team January 13, 2024 05:13
@zvecr zvecr merged commit eb7ecae into qmk:develop Jan 13, 2024
3 checks passed
@fauxpark fauxpark deleted the led-drivers-remove-offsets branch January 13, 2024 23:56
@fauxpark fauxpark mentioned this pull request Feb 19, 2024
14 tasks
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants