CLI: Allow generation of both LED and RGB Matrix config #22896
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While it is true that LED and RGB Matrix are mutually exclusive (mainly due to sharing of
g_led_config
), I have encountered this issue as a bit of an edge case with my testbed folder - Features are simply enabled in the keymap-level rules.mk, with most of the actual config living in the top-level or "dev-board"-level info.jsons.Since all of the LED/RGB Matrix config generated by the CLI is protected by feature ifdefs anyway, it should be safe to have both at once.
Types of Changes
Issues Fixed or Closed by This PR
Checklist