Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Allow generation of both LED and RGB Matrix config #22896

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

fauxpark
Copy link
Member

Description

While it is true that LED and RGB Matrix are mutually exclusive (mainly due to sharing of g_led_config), I have encountered this issue as a bit of an edge case with my testbed folder - Features are simply enabled in the keymap-level rules.mk, with most of the actual config living in the top-level or "dev-board"-level info.jsons.

Since all of the LED/RGB Matrix config generated by the CLI is protected by feature ifdefs anyway, it should be safe to have both at once.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 12, 2024 21:16
lib/python/qmk/info.py Outdated Show resolved Hide resolved
lib/python/qmk/info.py Outdated Show resolved Hide resolved
@zvecr zvecr merged commit 1bebaa3 into qmk:develop Jan 14, 2024
5 checks passed
@fauxpark fauxpark deleted the cli-led-rgb-matrix-config branch January 14, 2024 20:00
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants