Add combo key repress feature #22858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filios92
force-pushed
the
combo-repress
branch
from
81d904c to
f0173c2
Compare
|
Branch should be updated, but unit tests really should/need to be added. |
Filios92
force-pushed
the
combo-repress
branch
3 times, most recently
from
0f6d869 to
01904af
Compare
drashna
approved these changes
Feb 1, 2024
|
Thank you for your contribution! |
github-actions
bot
added
the
stale
drashna
added
awaiting review
and removed
stale
tzarc
added
breaking_change_2024q3
develop-fast-track
|
This has some merge conflicts that need to be resolved. |
Allows for running code for combo key repressing after release
waffle87
reviewed
Aug 26, 2024
waffle87
approved these changes
Aug 26, 2024
Co-authored-by: jack <[email protected]>
itsme-zeix
pushed a commit
to itsme-zeix/qmk_firmware
that referenced
this pull request
Oct 2, 2024
Co-authored-by: jack <[email protected]>
ilham-agustiawan
pushed a commit
to ilham-agustiawan/qmk_firmware
that referenced
this pull request
Nov 30, 2024
Co-authored-by: jack <[email protected]>
smallketchup82
pushed a commit
to smallketchup82/qmk_firmware
that referenced
this pull request
Dec 1, 2024
Co-authored-by: jack <[email protected]>
jlaptavi
pushed a commit
to jlaptavi/qmk_firmware
that referenced
this pull request
Dec 3, 2024
Co-authored-by: jack <[email protected]>
DmNosachev
pushed a commit
to DmNosachev/qmk_firmware
that referenced
this pull request
Dec 7, 2024
Co-authored-by: jack <[email protected]>
SyrupSplashin
pushed a commit
to SyrupSplashin/qmk_firmware
that referenced
this pull request
Dec 10, 2024
Co-authored-by: jack <[email protected]>
LeonMusCoden
pushed a commit
to LeonMusCoden/qmk_firmware
that referenced
this pull request
Jan 5, 2025
Co-authored-by: jack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for running code for combo key repressing after release
Description
A copy-paste from new docs:
By defining
COMBO_PROCESS_KEY_REPRESSand implementingbool process_combo_key_repress(uint16_t combo_index, combo_t *combo, uint8_t key_index, uint16_t keycode)you can run your custom code when you repress just released key of a combo. By combining it with customprocess_combo_eventwe can for example make special handling for Alt+Tab to switch windows, which, on combo F+G activation, registers Alt and presses Tab - then we can switch windows forward by releasing G and pressing it again, or backwards with F key.Types of Changes
Checklist