Ensure LED config is extracted when feature is disabled #22809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Jan 3, 2024
itsjonny96
pushed a commit
to itsjonny96/qmk_firmware
that referenced
this pull request
Jan 7, 2024
* Ensure LED config is extracted when feature is disabled * Only attempt LED search if dd led config is missing
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jan 17, 2024
* Ensure LED config is extracted when feature is disabled * Only attempt LED search if dd led config is missing
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jan 19, 2024
* Ensure LED config is extracted when feature is disabled * Only attempt LED search if dd led config is missing
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
* Ensure LED config is extracted when feature is disabled * Only attempt LED search if dd led config is missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the dd conversions, 22806 22807 22808, are failing due to the led config not being parsed (or led count being added) when the lighting feature is disabled by default.
If we have some dd config for a lighting feature, then we probably should still try and search for led config.
Likewise, if we already have position data, there is no point in trying to search for it.
Types of Changes
Issues Fixed or Closed by This PR
Checklist